From owner-freebsd-net@freebsd.org  Mon Aug 15 16:03:50 2016
Return-Path: <owner-freebsd-net@freebsd.org>
Delivered-To: freebsd-net@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id C73D0BBB179
 for <freebsd-net@mailman.ysv.freebsd.org>;
 Mon, 15 Aug 2016 16:03:50 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 9E8541C80
 for <freebsd-net@FreeBSD.org>; Mon, 15 Aug 2016 16:03:50 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u7FG3n2I068960
 for <freebsd-net@FreeBSD.org>; Mon, 15 Aug 2016 16:03:50 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-net@FreeBSD.org
Subject: [Bug 211836] Kernel panic with net.isr enabled
Date: Mon, 15 Aug 2016 16:03:50 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: kern
X-Bugzilla-Version: 11.0-RC1
X-Bugzilla-Keywords: crash, needs-patch, needs-qa
X-Bugzilla-Severity: Affects Many People
X-Bugzilla-Who: ae@FreeBSD.org
X-Bugzilla-Status: Open
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: Normal
X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org
X-Bugzilla-Flags: mfc-stable10? mfc-stable11?
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-211836-2472-rMErqsevdB@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-211836-2472@https.bugs.freebsd.org/bugzilla/>
References: <bug-211836-2472@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 15 Aug 2016 16:03:50 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D211836

--- Comment #10 from Andrey V. Elsukov <ae@FreeBSD.org> ---
(In reply to Babak Farrokhi from comment #9)
> Created attachment 173703 [details]
> textdump after applying patch from @ae
>=20
> Panicked again after patch

Ok, this is yet another case :)
Can you test this patch instead? It should cover both (all) cases.
The NETISR_DISPATCH_HYBRID case looks not quite correct, but it is better t=
han
panic...

Index: sys/net/netisr.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- sys/net/netisr.c    (revision 304101)
+++ sys/net/netisr.c    (working copy)
@@ -810,10 +810,12 @@ netisr_select_cpuid(struct netisr_proto *npp, u_in
                 * dispatch.  In the queued case, fall back on the SOURCE
                 * policy.
                 */
-               if (*cpuidp !=3D NETISR_CPUID_NONE)
+               if (*cpuidp !=3D NETISR_CPUID_NONE) {
+                       *cpuidp =3D nws_array[ *cpuidp % nws_count ];
                        return (m);
+               }
                if (dispatch_policy =3D=3D NETISR_DISPATCH_HYBRID) {
-                       *cpuidp =3D curcpu;
+                       *cpuidp =3D nws_array[ curcpu % nws_count ];
                        return (m);
                }
                policy =3D NETISR_POLICY_SOURCE;

--=20
You are receiving this mail because:
You are the assignee for the bug.=