From owner-freebsd-net@freebsd.org Tue Jul 14 00:39:13 2015 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A812C999B40 for ; Tue, 14 Jul 2015 00:39:13 +0000 (UTC) (envelope-from ricera10@gmail.com) Received: from mail-ie0-f180.google.com (mail-ie0-f180.google.com [209.85.223.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6DCB51EAD; Tue, 14 Jul 2015 00:39:12 +0000 (UTC) (envelope-from ricera10@gmail.com) Received: by iebmu5 with SMTP id mu5so1111630ieb.1; Mon, 13 Jul 2015 17:39:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-type; bh=VzwQyVkS1sPWMwRhymnhtiFwV6j49iZgEM/y6YOrOPw=; b=CTlzpGku2PYOPjYVkj8c03fuhcTKpLVmeq8SR4yVPsl7sGs7jDSlBKvmvzeuBeAi5l dxe0X0aRPeUjtltq0Vy8Ql8NmjsRh4QlFZT7Ck15yMWrOvmufyzlvhgoSY0LXsTHjDDd NeH4HV6jGJnytJXxAly6VbNslre2NlLDUT3V/olF0kzDgKl9sPTe4QsjG6Qj9iOLYbVr vVkjJij9yT84LwRBpUdszngi6FFaytt98vLLV4iZp2Gr09KcEegpln2VdrW3mEqgfP79 U0qhjbMVB+SZToq0X6DEelXb32sRiLJiDAE7ODVU8GczJx4cmRlcOuavE8KrFr3oEVN4 PN0w== X-Received: by 10.50.40.42 with SMTP id u10mr11758001igk.71.1436834346005; Mon, 13 Jul 2015 17:39:06 -0700 (PDT) Received: from mail-ig0-f169.google.com (mail-ig0-f169.google.com. [209.85.213.169]) by smtp.gmail.com with ESMTPSA id e69sm2547344ioe.31.2015.07.13.17.39.05 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 Jul 2015 17:39:05 -0700 (PDT) Received: by igbpg9 with SMTP id pg9so1249208igb.0; Mon, 13 Jul 2015 17:39:05 -0700 (PDT) X-Received: by 10.50.79.169 with SMTP id k9mr14411093igx.63.1436834345591; Mon, 13 Jul 2015 17:39:05 -0700 (PDT) MIME-Version: 1.0 References: <20150713200513.GD22795@strugglingcoder.info> In-Reply-To: From: Eric Joyner Date: Tue, 14 Jul 2015 00:38:56 +0000 Message-ID: Subject: Re: Exposing full 32bit RSS hash from card for ixgbe(4) To: Adrian Chadd , hiren panchasara Cc: FreeBSD Net , "scottl@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jul 2015 00:39:13 -0000 Sorry for the delay; it looked fine to me, but I never got back to you. - Eric On Mon, Jul 13, 2015 at 3:16 PM Adrian Chadd wrote: > Hi, > > It's fine by me. Please do it! > > > -a > > > On 13 July 2015 at 13:05, hiren panchasara wrote: > > Here is the patch I'd like to push which exposes 32bit RSS has that we > > get from ixgbe cards irrespective of whether RSS is defined or not. > > > > https://people.freebsd.org/~hiren/patches/ix_expose_rss_hash.patch > > > > This is similar to what we've done for igb(4): r281838 > > > > In this patch I am also proposing to remove FreeBSD version check (and > > therefore the check for M_FLOWID) as I don't see such a check in other > > Intel drivers like igb(4). But I am on adamant wrt that and can restore > > if someone feels strongly about it. > > > > (I need to update my arc client (again) to generate the phabric review > > and that can take some time so I'd appreciate any reviews/comments > > here.) > > > > Cheers, > > Hiren >