From owner-freebsd-current@FreeBSD.ORG  Mon Feb  9 11:33:28 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 5E67F16A4CE
	for <current@freebsd.org>; Mon,  9 Feb 2004 11:33:28 -0800 (PST)
Received: from orwell.lost-angel.com (134.153.252.64.snet.net
	[64.252.153.134])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 0161043D1D
	for <current@freebsd.org>; Mon,  9 Feb 2004 11:33:28 -0800 (PST)
	(envelope-from sammy@lost-angel.com)
Received: from [192.168.1.5] (darwin.euplastic.com [192.168.1.5])
	(authenticated bits=0)i19JUuCs060228
	(version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NO)
	for <current@freebsd.org>; Mon, 9 Feb 2004 14:30:56 -0500 (EST)
	(envelope-from sammy@lost-angel.com)
Mime-Version: 1.0 (Apple Message framework v612)
In-Reply-To: <40272C79.6040708@freebsd.org>
References: <EE3D3FBAFFCAED448C21C398FDAD91AC0108FC@EBE1.gc.nat>
	<40247AE9.6070805@gddsn.org.cn> <20040207062617.GC49373@teleri.net>
	<20040209063331.A11582@farside.isc.org> <40272C79.6040708@freebsd.org>
Content-Type: text/plain; charset=US-ASCII; format=flowed
Message-Id: <D52A541C-5B36-11D8-8C86-0003934BF296@lost-angel.com>
Content-Transfer-Encoding: 7bit
From: sammy!!! <sammy@lost-angel.com>
Date: Mon, 9 Feb 2004 14:33:27 -0500
To: current@freebsd.org
X-Mailer: Apple Mail (2.612)
Subject: Re: Processes blocked on getblk or ufs
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 09 Feb 2004 19:33:28 -0000

Has anyone verified this for RELENG_5_2?


On Feb 9, 2004, at 1:45 AM, Scott Long wrote:

> Peter Losher wrote:
>> On Sat, 7 Feb 2004, Chip Norkus wrote:
>>>> woo,  Scott's commit seem to fix this problem for me!
>>>>
>>>
>>> I think I can throw a 'me too' in here.  A build (make -j8 world) 
>>> which
>>> would reliably lock up one of my 2650s no longer does so.  This is
>>> extremely encouraging. :)  Thanks so much for the hard work on this!
>> Any chance this can be backported to RELENG_5_2?  Because as it is 
>> now 5.2
>> is unusable on Dell systems using the aac driver.
>> -Peter
>
> Can you try the attached patch?
>
> Scott
> Index: aac.c
> ===================================================================
> RCS file: /usr/ncvs/src/sys/dev/aac/aac.c,v
> retrieving revision 1.81
> diff -u -r1.81 aac.c
> --- aac.c	9 Nov 2003 09:17:20 -0000	1.81
> +++ aac.c	9 Feb 2004 06:41:57 -0000
> @@ -1290,8 +1290,10 @@
>  	cm->cm_flags |= AAC_CMD_MAPPED;
>
>  	/* put the FIB on the outbound queue */
> -	if (aac_enqueue_fib(sc, cm->cm_queue, cm) == EBUSY)
> +	if (aac_enqueue_fib(sc, cm->cm_queue, cm) == EBUSY) {
> +		aac_unmap_command(cm);
>  		aac_requeue_ready(cm);
> +	}
>
>  	return;
>  }
> _______________________________________________
> freebsd-current@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to 
> "freebsd-current-unsubscribe@freebsd.org"