From owner-freebsd-ports@FreeBSD.ORG Thu Sep 18 21:38:02 2008 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 38B9C1065670; Thu, 18 Sep 2008 21:38:02 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id AE15A8FC1E; Thu, 18 Sep 2008 21:38:01 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [IPv6:::1]) (authenticated bits=0) by server.baldwin.cx (8.14.2/8.14.2) with ESMTP id m8ILbngf020803; Thu, 18 Sep 2008 17:37:55 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Alex Dupre Date: Thu, 18 Sep 2008 15:45:48 -0400 User-Agent: KMail/1.9.7 References: <200809151036.19674.jhb@freebsd.org> <200809181033.56619.jhb@freebsd.org> <48D2A979.7090809@FreeBSD.org> In-Reply-To: <48D2A979.7090809@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200809181545.48487.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [IPv6:::1]); Thu, 18 Sep 2008 17:37:55 -0400 (EDT) X-Virus-Scanned: ClamAV 0.93.1/8282/Thu Sep 18 14:21:01 2008 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.5 required=4.2 tests=AWL,BAYES_00,NO_RELAYS, SUBJECT_EXCESS_QP autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: ports@freebsd.org, Doug Barton Subject: Re: OPTIONS handling doesn't seem to work fully in dependencies anymore X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Sep 2008 21:38:02 -0000 On Thursday 18 September 2008 03:18:17 pm Alex Dupre wrote: > John Baldwin wrote: > > Trust me, since I rebuild from scratch all the time, I quite remember when > > options were first added and I'd kick off a build of kde or some such > > overnight and check my screen session in the morning only find it hadn't > > build hardly anything b/c it had popped up the option screen for gettext. :) > > Me, too, really :-) But kde3 meta-port doesn't use the OPTIONS > framework, even if it displays the dialog box. And when the OPTIONS > framework was added, very few ports actually used it, so it was very > very rare to incur in *direct* dependencies between two OPTIONS-enabled > ports. The kde4 meta-port now uses it, so it became obvious that > something wasn't working as expected when you tried to build it. Ahh, I think I see now. It requires one OPTIONS using port to mask the dependencies. > > I wonder why it has to be this hackish btw. Could config-conditional simply > > be in the list of targets before 'fetch' or some such? > > I thought the same thing, probably yes, but I dunno why it was added in > such way from the beginning, so I tried to create the simplest and > surely working patch maintaining the current workflow. Ok. -- John Baldwin