From owner-cvs-all@FreeBSD.ORG Mon May 16 15:47:55 2005 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 99C8A16A4CE; Mon, 16 May 2005 15:47:55 +0000 (GMT) Received: from aiolos.otenet.gr (aiolos.otenet.gr [195.170.0.23]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9FF1343D67; Mon, 16 May 2005 15:47:54 +0000 (GMT) (envelope-from keramida@freebsd.org) Received: from orion.daedalusnetworks.priv (aris.bedc.ondsl.gr [62.103.39.226])j4GFkAAg018340; Mon, 16 May 2005 18:46:10 +0300 Received: from orion.daedalusnetworks.priv (orion [127.0.0.1]) j4GFllAG039761; Mon, 16 May 2005 18:47:47 +0300 (EEST) (envelope-from keramida@freebsd.org) Received: (from keramida@localhost)j4GFlkFD039752; Mon, 16 May 2005 18:47:46 +0300 (EEST) (envelope-from keramida@freebsd.org) Date: Mon, 16 May 2005 18:47:46 +0300 From: Giorgos Keramidas To: "David O'Brien" Message-ID: <20050516154746.GA31676@orion.daedalusnetworks.priv> References: <200504161543.j3GFhclO075103@repoman.freebsd.org> <20050516001837.GA65506@dragon.NUXI.org> <20050516004059.GA15002@gothmog.gr> <20050516032743.GA89903@dragon.NUXI.org> <20050516101515.GA676@orion.daedalusnetworks.priv> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050516101515.GA676@orion.daedalusnetworks.priv> cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/usr.bin/top machine.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 May 2005 15:47:55 -0000 On 2005-05-16 13:15, Giorgos Keramidas wrote: > If you think that hard-limiting USERNAME to 8 columns is fine, then I'm > all for it, please commit :-) Ok, I've tested the same change here too. It seems to work fine (except for the minor nit of using a statically initialized variable for something that can be a constant, but top has so many ``buglets'' already that this is not too important). The version of top that I used on my workstation at work today includes the following changes: - Proper trimming of the header to avoid the nasty wraparound of the header that BDE mentioned. - Hard-limiting of USERNAME to 8 columns. - Merged CPU/WCPU columns that can be toggled with 'C'. The sources for this are available at: http://people.freebsd.org/~keramida/top-keramida.tgz The CVS tree where I worked on these changes is available online too, at: http://serverhive.com/cgi-bin/cvsweb.cgi/freebsd/top/?cvsroot=pcvs David, do you think you could review and/or commit some of the changes if I posted the diffs to you? - Giorgos