From owner-freebsd-alpha Tue Oct 26 0:39:34 1999 Delivered-To: freebsd-alpha@freebsd.org Received: from herring.nlsystems.com (nlsys.demon.co.uk [158.152.125.33]) by hub.freebsd.org (Postfix) with ESMTP id 41EB314C48 for ; Tue, 26 Oct 1999 00:39:28 -0700 (PDT) (envelope-from dfr@nlsystems.com) Received: from salmon.nlsystems.com (salmon.nlsystems.com [10.0.0.3]) by herring.nlsystems.com (8.9.3/8.8.8) with ESMTP id IAA29992; Tue, 26 Oct 1999 08:39:20 +0100 (BST) (envelope-from dfr@nlsystems.com) Date: Tue, 26 Oct 1999 08:39:20 +0100 (BST) From: Doug Rabson To: Andrew Gallatin Cc: alpha@freebsd.org Subject: Re: small fix for irq mappig probelm In-Reply-To: <14354.8792.767477.900314@grasshopper.cs.duke.edu> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-alpha@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org On Sat, 23 Oct 1999, Andrew Gallatin wrote: > > Doug, > > When using a kernel built after your recent changes to pci.c, alpha > PCI devices with intline==0 fail to map their interrupt. This > typically happens with the on-board tulip in a miata: > > de0: irq 0 at device 3.0 on pci0 > pci_map_int: can't allocate interrupt > > > The appended patch fixes it, but I am unsure it is correct. Can you > approve it? > > Thanks, I think the correct fix is to compare against 255. I will commit the following patch: Index: pci.c =================================================================== RCS file: /home/ncvs/src/sys/pci/pci.c,v retrieving revision 1.123 diff -u -r1.123 pci.c --- pci.c 1999/10/17 06:48:47 1.123 +++ pci.c 1999/10/26 07:36:14 @@ -1045,7 +1045,7 @@ (unsigned int) base, ln2size); } } - if (cfg->intline) + if (cfg->intline != 255) resource_list_add(rl, SYS_RES_IRQ, 0, cfg->intline, cfg->intline, 1); } -- Doug Rabson Mail: dfr@nlsystems.com Nonlinear Systems Ltd. Phone: +44 181 442 9037 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-alpha" in the body of the message