From owner-freebsd-current@FreeBSD.ORG Wed Jun 15 02:36:02 2005 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 556B516A41C for ; Wed, 15 Jun 2005 02:36:02 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id F2DDC43D1F for ; Wed, 15 Jun 2005 02:36:01 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (obrien@localhost [127.0.0.1]) by dragon.NUXI.org (8.13.4/8.13.4) with ESMTP id j5F2a1gf021019; Tue, 14 Jun 2005 19:36:01 -0700 (PDT) (envelope-from obrien@dragon.NUXI.org) Received: (from obrien@localhost) by dragon.NUXI.org (8.13.4/8.13.1/Submit) id j5F2a0NP021018; Tue, 14 Jun 2005 19:36:00 -0700 (PDT) (envelope-from obrien) Date: Tue, 14 Jun 2005 19:36:00 -0700 From: "David O'Brien" To: Maxim Konovalov Message-ID: <20050615023600.GA20721@dragon.NUXI.org> Mail-Followup-To: freebsd-current@freebsd.org, Maxim Konovalov , Ed Maste References: <20050613192308.GA87640@sandvine.com> <20050614082039.GA2038@dragon.NUXI.org> <20050614224704.Y75797@mp2.macomnet.net> <20050614190854.GA12928@dragon.NUXI.org> <20050614235132.L76669@mp2.macomnet.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050614235132.L76669@mp2.macomnet.net> X-Operating-System: FreeBSD 6.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 User-Agent: Mutt/1.5.9i Cc: freebsd-current@freebsd.org, Ed Maste Subject: Re: savecore(8) increments /var/crash/bounds on each boot X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: freebsd-current@freebsd.org List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jun 2005 02:36:02 -0000 On Wed, Jun 15, 2005 at 12:10:05AM +0400, Maxim Konovalov wrote: > On Tue, 14 Jun 2005, 12:08-0700, David O'Brien wrote: > > > On Tue, Jun 14, 2005 at 10:49:44PM +0400, Maxim Konovalov wrote: > > > On Tue, 14 Jun 2005, 01:20-0700, David O'Brien wrote: > > > > > > > On Mon, Jun 13, 2005 at 03:23:08PM -0400, Ed Maste wrote: > > > > > I notice that as of sbin/savecore/savecore.c 1.72 and in 5.4-RELEASE > > > > > savecore increments the number in /var/crash/bounds on each boot, > > > > > regardless of whether it rebooted due to panic or was a clean shutdown. > > > > > Is this the desired behaviour or an unintentional side effect? > > > > > > > > It is an unintentional side affect. If I wasn't constantly experiencing > > > > kernel landminds every time I sit down to do major FreeBSD, I would have > > > > gotten to this issue. > > > > > > I am going to ask re@ for permission to commit the fix if nobody beats > > > me. > > > > Are you sure its correct? Have you tested it with say bounds != 0 and a > > few core dumps in /var/crash? > > No problems so far: Do you understand the fix? How does lying in printheader() fix anything? Moving the call to getbounds() back to the original location is the "fix" but then it negates -vv. We shouldn't lie in printheader(). -- -- David (obrien@FreeBSD.org)