From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Jul 14 16:10:07 2008 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DA87C1065675 for ; Mon, 14 Jul 2008 16:10:07 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id C51878FC28 for ; Mon, 14 Jul 2008 16:10:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m6EGA2Vg044364 for ; Mon, 14 Jul 2008 16:10:02 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m6EGA2a7044363; Mon, 14 Jul 2008 16:10:02 GMT (envelope-from gnats) Resent-Date: Mon, 14 Jul 2008 16:10:02 GMT Resent-Message-Id: <200807141610.m6EGA2a7044363@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Marcin Wisnicki Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E11CA1065682 for ; Mon, 14 Jul 2008 16:08:55 +0000 (UTC) (envelope-from mwisnicki@gmail.com) Received: from fg-out-1718.google.com (fg-out-1718.google.com [72.14.220.153]) by mx1.freebsd.org (Postfix) with ESMTP id 7B4428FC12 for ; Mon, 14 Jul 2008 16:08:55 +0000 (UTC) (envelope-from mwisnicki@gmail.com) Received: by fg-out-1718.google.com with SMTP id l26so3419128fgb.35 for ; Mon, 14 Jul 2008 09:08:54 -0700 (PDT) Received: by 10.86.28.2 with SMTP id b2mr14588030fgb.20.1216051734193; Mon, 14 Jul 2008 09:08:54 -0700 (PDT) Received: from ghost.pnet.one.pl ( [84.40.242.20]) by mx.google.com with ESMTPS id 4sm7506130fgg.9.2008.07.14.09.08.52 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 14 Jul 2008 09:08:53 -0700 (PDT) Received: by ghost.pnet.one.pl (sSMTP sendmail emulation); Mon, 14 Jul 2008 18:08:50 +0200 Message-Id: <487b7a15.0407560a.3ad8.6020@mx.google.com> Date: Mon, 14 Jul 2008 18:08:50 +0200 From: Marcin Wisnicki Sender: =?UTF-8?B?TWFyY2luIFdpxZtuaWNraQ==?= To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: gnome@FreeBSD.org Subject: ports/125607: [PATCH] x11/xscreensaver-gnome: pam option is broken X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jul 2008 16:10:07 -0000 >Number: 125607 >Category: ports >Synopsis: [PATCH] x11/xscreensaver-gnome: pam option is broken >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Mon Jul 14 16:10:02 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Marcin Wisnicki >Release: FreeBSD 7.0-STABLE i386 >Organization: >Environment: System: FreeBSD ghost.pnet.one.pl 7.0-STABLE FreeBSD 7.0-STABLE #13: Sun Jul 6 16:19:06 CEST >Description: There is an obvious mistake in WITH_PAM case, which in addition to disabling pam support causes plist breakage. While there, enable PAM by default. PLEASE do not reject this unless you have a good technical reason to do so. PAM is a stable and standard component of FreeBSD base system since years. It is unconditionally enabled in x11/gdm. Also, remove kerberos option, it's misleading and deprecated. More than likely any user of Kerberos will prefer to do it through PAM. Port maintainer (gnome@FreeBSD.org) is cc'd. Generated with FreeBSD Port Tools 0.77 >How-To-Repeat: >Fix: --- xscreensaver-gnome-5.05_1.patch begins here --- diff -ruN --exclude=CVS /usr/ports/x11/xscreensaver-gnome.orig/Makefile /usr/ports/x11/xscreensaver-gnome/Makefile --- /usr/ports/x11/xscreensaver-gnome.orig/Makefile 2008-07-10 01:40:06.000000000 +0200 +++ /usr/ports/x11/xscreensaver-gnome/Makefile 2008-07-14 17:45:04.000000000 +0200 @@ -8,7 +8,7 @@ PORTNAME?= xscreensaver-gnome PORTVERSION= 5.05 -PORTREVISION?= 0 +PORTREVISION?= 1 CATEGORIES= x11 gnome MASTER_SITES= http://www.jwz.org/xscreensaver/ DISTNAME= xscreensaver-${PORTVERSION} @@ -36,8 +36,7 @@ CONFIGURE_ENV= CPPFLAGS="-I${LOCALBASE}/include" \ LDFLAGS="-L${LOCALBASE}/lib" -OPTIONS?= PAM "Pluggable Authentication Module support" off \ - KERBEROS "Add support for kerberos" off \ +OPTIONS?= PAM "Pluggable Authentication Module support" on \ ALL_FORTUNES "Enable support for all fortunes" off \ SETUID_HACKS "Install sonar hack suid so it can ping" off @@ -89,18 +88,12 @@ .if defined(WITH_PAM) PLIST_SUB+= PAM="" -CONFIGURE_ARGS+= --without-pam +CONFIGURE_ARGS+= --with-pam .else CONFIGURE_ARGS+= --without-pam PLIST_SUB+= PAM="@comment " .endif -.if defined(WITH_KERBEROS) -CONFIGURE_ARGS+= --with-kerberos -.else -CONFIGURE_ARGS+= --without-kerberos -.endif - .if defined(WITH_SETUID_HACKS) CONFIGURE_ARGS+= --with-setuid-hacks .endif --- xscreensaver-gnome-5.05_1.patch ends here --- >Release-Note: >Audit-Trail: >Unformatted: