From owner-svn-src-head@FreeBSD.ORG Tue Apr 17 06:59:53 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id ABE831065670; Tue, 17 Apr 2012 06:59:33 +0000 (UTC) (envelope-from pluknet@gmail.com) Received: from mail-lpp01m010-f54.google.com (mail-lpp01m010-f54.google.com [209.85.215.54]) by mx1.freebsd.org (Postfix) with ESMTP id B55CB8FC0A; Tue, 17 Apr 2012 06:59:12 +0000 (UTC) Received: by lagv3 with SMTP id v3so5753470lag.13 for ; Mon, 16 Apr 2012 23:59:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type :content-transfer-encoding; bh=KXbVHEwsiVpiziD1ZNAfnyaGvQSL3vcN2ope2Aju6Dc=; b=MoBcRL8oprhZVP/i5tbIr5vrqaYAv8O4uKDqvyI6FN/SvoHdwc7Z0UQvWRw1ZXGxo7 HZNgvs0x1H4hu19LOqBPjE/E2PBsJ54Oq8Zt32lo9H1Pk76wVhbgSyyHCmg1mFFjRd0i r1Ss1++/dWwStA/RTP9BvloEBBo6aPpOLyzgN2r9hiS8RomCsTeDWqcB5ThOEeciUOyW Og/D0hcVLjJeuR3vXffQNu91z3V2iHZYKoTGw/XhJ0TWEpnrPFOhiRoqPihr+bCp8I/b fNJGPsqVwLH9lObYzYIe4z4CZYK7TeRs1DVJc8xHOxL/9T36CVG3AWzPAY5nKc7boQ7g cNZA== MIME-Version: 1.0 Received: by 10.112.25.130 with SMTP id c2mr6501496lbg.107.1334645951707; Mon, 16 Apr 2012 23:59:11 -0700 (PDT) Sender: pluknet@gmail.com Received: by 10.152.25.69 with HTTP; Mon, 16 Apr 2012 23:59:11 -0700 (PDT) In-Reply-To: <20120414113132.GA71196@felucia.tataz.chchile.org> References: <201203220942.q2M9gSvv017339@svn.freebsd.org> <20120414113132.GA71196@felucia.tataz.chchile.org> Date: Tue, 17 Apr 2012 10:59:11 +0400 X-Google-Sender-Auth: 06QgVKWVBC9yqsJkm049qXa0_ps Message-ID: From: Sergey Kandaurov To: Jeremie Le Hen , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: Subject: Re: svn commit: r233296 - head/lib/libc/gen X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Apr 2012 06:59:53 -0000 On 14 April 2012 15:31, Jeremie Le Hen wrote: > Hi Sergey, > > On Thu, Mar 22, 2012 at 09:42:28AM +0000, Sergey Kandaurov wrote: >> Author: pluknet >> Date: Thu Mar 22 09:42:27 2012 >> New Revision: 233296 >> URL: http://svn.freebsd.org/changeset/base/233296 >> >> Log: >> =A0 Prevent fs_file NULL pointer dereference in fixfsfile() uncovered af= ter r1.5 >> =A0 when passing damaged user-supplied fstab file data. >> >> =A0 MFC after: =A01 week >> >> Modified: >> =A0 head/lib/libc/gen/fstab.c >> >> Modified: head/lib/libc/gen/fstab.c >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >> --- head/lib/libc/gen/fstab.c Thu Mar 22 09:29:07 2012 =A0 =A0 =A0 =A0(r= 233295) >> +++ head/lib/libc/gen/fstab.c Thu Mar 22 09:42:27 2012 =A0 =A0 =A0 =A0(r= 233296) >> @@ -91,7 +91,7 @@ fixfsfile() >> =A0 =A0 =A0 struct stat sb; >> =A0 =A0 =A0 struct statfs sf; >> >> - =A0 =A0 if (strcmp(_fs_fstab.fs_file, "/") !=3D 0) >> + =A0 =A0 if (_fs_fstab.fs_file !=3D NULL &&strcmp(_fs_fstab.fs_file, "/= ") !=3D 0) >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 return; >> =A0 =A0 =A0 if (statfs("/", &sf) !=3D 0) >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 return; > > Would you mind MFC'ing this please? =A0It bit me today :). > > Thanks. Ah, sure. I will today. [I was AFK for some time, and now I'm here again.] --=20 wbr, pluknet