From owner-freebsd-current@freebsd.org Sun Dec 31 22:48:03 2017 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7354CEAB854 for ; Sun, 31 Dec 2017 22:48:03 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from c.mail.sonic.net (c.mail.sonic.net [64.142.111.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 5E9A667D06 for ; Sun, 31 Dec 2017 22:48:03 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from comporellon.tachypleus.net (cpe-75-82-218-62.socal.res.rr.com [75.82.218.62]) (authenticated bits=0) by c.mail.sonic.net (8.15.1/8.15.1) with ESMTPSA id vBVMbWi7029488 (version=TLSv1.2 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT) for ; Sun, 31 Dec 2017 14:37:33 -0800 Subject: Re: SVN r327444 breaks current build To: freebsd-current@freebsd.org References: <0b8f0e34-7a39-fd59-7f66-b55f1af0e920@protected-networks.net> <20171231222235.GA62313@bluezbox.com> From: Nathan Whitehorn Message-ID: Date: Sun, 31 Dec 2017 14:37:32 -0800 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171231222235.GA62313@bluezbox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Sonic-CAuth: UmFuZG9tSVa2LlaHJCJ2e/nw2ICFt/7AuH7GyBv6mDW+JJS7ORJOQw7p1x/UayYo6yifQBB294uiEir/SpBu0SGrprj93s3+OyfVjrK2L9g= X-Sonic-ID: C;5uP3MHvu5xGsFc8r2KTi7g== M;4KhRMXvu5xGsFc8r2KTi7g== X-Spam-Flag: No X-Sonic-Spam-Details: 0.0/5.0 by cerberusd X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Dec 2017 22:48:03 -0000 On 12/31/17 14:22, Oleksandr Tymoshenko wrote: > Michael Butler (imb@protected-networks.net) wrote: >> Building /usr/obj/usr/src/amd64.amd64/sys/VM01/vt_font_default.o >> --- vt_termcolors.o --- >> /usr/src/sys/dev/vt/colors/vt_termcolors.c:158:55: error: too many >> arguments to function call, expected 4, have 5 >> if (vt_parse_rgb_triplet(rgb, strlen(rgb), &r, >> &g, &b) == 0) { >> ~~~~~~~~~~~~~~~~~~~~ >> ^~ >> /usr/src/sys/dev/vt/colors/vt_termcolors.c:77:1: note: >> 'vt_parse_rgb_triplet' declared here >> static int >> ^ >> 1 error generated. >> *** [vt_termcolors.o] Error code 1 >> >> .. second time today a commit wasn't tested before commit :-( >> >> imb > Should be fixed in r327449. It was a sloppy job, I was making iterative > improvements to the original patch following review feedback and used > out-of-tree testcases for actual testing. I appologize for the breakage. > Still broken with GCC. /usr/src/sys/dev/vt/colors/vt_termcolors.c:148: warning: function declaration isn't a prototype [-Wstrict-prototypes] *** [vt_termcolors.o] Error code 1 -Nathan