From owner-freebsd-ports@FreeBSD.ORG Fri Jul 9 18:07:32 2010 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B7BF1106566C for ; Fri, 9 Jul 2010 18:07:32 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with ESMTP id 6067F8FC14 for ; Fri, 9 Jul 2010 18:07:32 +0000 (UTC) Received: (qmail 26080 invoked by uid 399); 9 Jul 2010 18:07:31 -0000 Received: from localhost (HELO laptop.dougb.net) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 9 Jul 2010 18:07:31 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <4C376562.5000809@FreeBSD.org> Date: Fri, 09 Jul 2010 11:07:30 -0700 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.9.1.10) Gecko/20100701 Thunderbird/3.0.5 MIME-Version: 1.0 To: John Baldwin References: <201007081750.00871.jhb@freebsd.org> <201007090827.09471.jhb@freebsd.org> In-Reply-To: <201007090827.09471.jhb@freebsd.org> X-Enigmail-Version: 1.0.1 OpenPGP: id=1A1ABC84 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: ports@freebsd.org Subject: Re: Review request for new port: sysutils/etcupdate X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Jul 2010 18:07:32 -0000 On 07/09/10 05:27, John Baldwin wrote: > On Thursday, July 08, 2010 6:12:39 pm Doug Barton wrote: >> On Thu, 8 Jul 2010, John Baldwin wrote: >> >>> This is a port for yet-another-/etc-merging tool that I wrote recently. > It >>> passes portlint -N with one bogus warning because /etc is in the comment. >> >> I didn't try installing/deinstalling but you seem to have the right >> stuff in the Makefile for that. Overall it looks good, just a couple >> comments: >> 1. I don't think textproc is right for CATEGORIES, although sysutils is >> of course. >> 2. I don't think the do-fetch target is necessary, but if it is needed >> when you test it that's fine. >> 3. You have a pkg-descr~ file in the shar that should be deleted before >> you commit it. >> >> Assuming it passes all the tests in the porter's handbook for install, >> deinstall, package, etc. I'd say go ahead. :) > > Ok. Should I fix 1) and 2) for the sysutils/etcmerge port as well? (I used > etcmerge as a template.) I think removing textproc is a no-brainer, unless someone has a different opinion. :) I don't have a do-fetch target in portmaster's port (which also has the src in the tree), and given the fact that DISTFILES is explicitly set empty I don't see why one would be necessary at all. So, short answer, yes, if you don't mind. Otherwise I'll be glad to do it, just let me know. Doug -- ... and that's just a little bit of history repeating. -- Propellerheads Improve the effectiveness of your Internet presence with a domain name makeover! http://SupersetSolutions.com/