From owner-freebsd-firewire@FreeBSD.ORG  Sun Aug 17 23:10:22 2008
Return-Path: <owner-freebsd-firewire@FreeBSD.ORG>
Delivered-To: freebsd-firewire@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 454AA1065671;
	Sun, 17 Aug 2008 23:10:22 +0000 (UTC)
	(envelope-from freebsd@sopwith.solgatos.com)
Received: from parsely.rain.com (parsely.rain.com [199.26.172.196])
	by mx1.freebsd.org (Postfix) with ESMTP id 90DEA8FC18;
	Sun, 17 Aug 2008 23:10:21 +0000 (UTC)
	(envelope-from freebsd@sopwith.solgatos.com)
Received: from sopwith.solgatos.com (uucp@localhost)
	by parsely.rain.com (8.11.4/8.11.4) with UUCP id m7HNA7G49547;
	Sun, 17 Aug 2008 16:10:07 -0700 (PDT)
	(envelope-from freebsd@sopwith.solgatos.com)
Received: from localhost by sopwith.solgatos.com (8.8.8/6.24)
	id XAA21188; Sun, 17 Aug 2008 23:09:07 GMT
Message-Id: <200808172309.XAA21188@sopwith.solgatos.com>
To: Sean Bruno <sbruno@miralink.com>
In-reply-to: Your message of "Sun, 17 Aug 2008 10:34:50 PDT."
	<48A8613A.4000506@miralink.com> 
Date: Sun, 17 Aug 2008 16:09:07 +0100
From: Dieter <freebsd@sopwith.solgatos.com>
Cc: Scott Long <scottl@samsco.org>, freebsd-firewire@freebsd.org
Subject: Re: fwcontrol update 
X-BeenThere: freebsd-firewire@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Firewire support in FreeBSD <freebsd-firewire.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-firewire>, 
	<mailto:freebsd-firewire-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-firewire>
List-Post: <mailto:freebsd-firewire@freebsd.org>
List-Help: <mailto:freebsd-firewire-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-firewire>, 
	<mailto:freebsd-firewire-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 17 Aug 2008 23:10:22 -0000

> >> len = read(fd, buf, 1024*16);
> >
> > It would be good practice to check for read failing.
>
> Indeed it would.  I looked into fwdev.c::fw_read() a little bit and 
> documented what I think it's doing as well.

> BTW, did the compile warnings on AMD64 go away? 

I still need to give it a closer inspection, and run some tests,
but it looks good so far.  And gcc isn't complaining (7.0 on AMD64).