Date: Wed, 08 Nov 2023 21:56:37 +0000 From: bugzilla-noreply@freebsd.org To: pf@FreeBSD.org Subject: [Bug 274915] panic immediately on loading ruleset, in pf_ioctl_addrule sha #4ffe410 Message-ID: <bug-274915-16861-cvCBzdy3d0@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-274915-16861@https.bugs.freebsd.org/bugzilla/> References: <bug-274915-16861@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D274915 --- Comment #7 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3Da6246a50b63450d0fe34e3429807bd5ab= a8cc2ac commit a6246a50b63450d0fe34e3429807bd5aba8cc2ac Author: Kristof Provost <kp@FreeBSD.org> AuthorDate: 2023-11-08 14:06:15 +0000 Commit: Kristof Provost <kp@FreeBSD.org> CommitDate: 2023-11-08 20:58:52 +0000 pf: fix double free if pf_ioctl_addrule() fails If pf_ioctl_addrule() returns an error it will have freed the rule itself. There's no need for the caller to free it again. PR: 274915 Reported by: Dave Cottlehuber <dch@FreeBSD.org> MFC after: 1 week Sponsored by: Rubicon Communications, LLC ("Netgate") sys/netpfil/pf/pf_nl.c | 3 --- 1 file changed, 3 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-274915-16861-cvCBzdy3d0>