From owner-freebsd-bugs  Tue Feb 22 22:20: 4 2000
Delivered-To: freebsd-bugs@freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
	by hub.freebsd.org (Postfix) with ESMTP id 037CB37B6FE
	for <freebsd-bugs@FreeBSD.org>; Tue, 22 Feb 2000 22:20:02 -0800 (PST)
	(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.9.3/8.9.2) id WAA63302;
	Tue, 22 Feb 2000 22:20:01 -0800 (PST)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
	by hub.freebsd.org (Postfix) with ESMTP id 0AA6337B836
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 22 Feb 2000 22:14:59 -0800 (PST)
	(envelope-from nobody@FreeBSD.org)
Received: (from nobody@localhost)
	by freefall.freebsd.org (8.9.3/8.9.2) id WAA63075;
	Tue, 22 Feb 2000 22:14:58 -0800 (PST)
	(envelope-from nobody@FreeBSD.org)
Message-Id: <200002230614.WAA63075@freefall.freebsd.org>
Date: Tue, 22 Feb 2000 22:14:58 -0800 (PST)
From: spock@techfour.net
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-1.0
Subject: bin/16927: [PATCH] prevent possible race condition in lorder.sh
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org


>Number:         16927
>Category:       bin
>Synopsis:       [PATCH] prevent possible race condition in lorder.sh
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Feb 22 22:20:01 PST 2000
>Closed-Date:
>Last-Modified:
>Originator:     Mike Heffner
>Release:        4.0-current
>Organization:
>Environment:
FreeBSD 4.0-CURRENT #0: Sat Feb 19 20:05:45 EST 2000
>Description:
lorder.sh should use harder to predict tempfiles instead of:
/tmp/_reference_{pid}
/tmp/_symbol_{pid}
>How-To-Repeat:
run lorder
>Fix:
apply patch and recompile.

Index: usr.bin/lorder/lorder.sh
===================================================================
RCS file: /home/ncvs/src/usr.bin/lorder/lorder.sh,v
retrieving revision 1.2
diff -u -r1.2 lorder.sh
--- lorder.sh   1998/08/15 07:10:21     1.2
+++ lorder.sh   2000/01/29 20:13:45
@@ -45,8 +45,8 @@
 esac

 # temporary files
-R=/tmp/_reference_$$
-S=/tmp/_symbol_$$
+R=`mktemp /tmp/_reference_XXXXXXXXXX`
+S=`mktemp /tmp/_symbol_XXXXXXXXXX`

 # remove temporary files on HUP, INT, QUIT, PIPE, TERM
 trap "rm -f $R $S; exit 1" 1 2 3 13 15



>Release-Note:
>Audit-Trail:
>Unformatted:


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message