From owner-freebsd-ports@FreeBSD.ORG Sun Sep 25 15:24:13 2011 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7A7D2106566B; Sun, 25 Sep 2011 15:24:13 +0000 (UTC) (envelope-from amdmi3@amdmi3.ru) Received: from smtp.timeweb.ru (smtp.timeweb.ru [92.53.116.15]) by mx1.freebsd.org (Postfix) with ESMTP id 3124B8FC0C; Sun, 25 Sep 2011 15:24:12 +0000 (UTC) Received: from [213.148.20.85] (helo=hive.panopticon) by smtp.timeweb.ru with esmtpsa (TLSv1:CAMELLIA256-SHA:256) (Exim 4.76) (envelope-from ) id 1R7qYs-0006hI-Se; Sun, 25 Sep 2011 19:24:10 +0400 Received: from hades.panopticon (hades.panopticon [192.168.0.32]) by hive.panopticon (Postfix) with ESMTP id 1A008B84D; Sun, 25 Sep 2011 19:24:07 +0400 (MSD) Received: by hades.panopticon (Postfix, from userid 1000) id 0DA4FB825; Sun, 25 Sep 2011 19:24:07 +0400 (MSD) Date: Sun, 25 Sep 2011 19:24:07 +0400 From: Dmitry Marakasov To: Lev Serebryakov Message-ID: <20110925152406.GC72921@hades.panopticon> References: <20110907032718.GJ42123@hades.panopticon> <20110923233613.GA72659@hades.panopticon> <64679963.20110925144136@serebryakov.spb.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <64679963.20110925144136@serebryakov.spb.ru> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: freebsd-ports@freebsd.org Subject: Re: LDFLAGS support for bsd.port.mk and CPPFLAGS/LDFLAGS cleanup X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Sep 2011 15:24:13 -0000 * Lev Serebryakov (lev@FreeBSD.org) wrote: > > The patch was committed, LDFLAGS and CPPFLAGS and now handled > > similarily, shouldn't be passed to CONFIGURE_ENV and should be > > altered by += like C/CXXFLAGS. > Add devel/dbus-glib to the list... > Should I make formal PR for all these ports? All three ports build here without problems (sqlite3 with ICU option enabled as well), tinderbox shows no problem either. Here's sqlite3+icu log, for example: http://people.freebsd.org/~amdmi3/sqlite3-icu-3.7.8.log configure command shows that LDFLAGS is used as expected after patch. There has also been a set of exp-runs before I committed the patch, last of which showed no breakages. Please double check your ports tree is in consistent state. If there's a problem with specific CVS mirror, this should be reported. -- Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D amdmi3@amdmi3.ru ..: jabber: amdmi3@jabber.ru http://www.amdmi3.ru