From owner-freebsd-current@FreeBSD.ORG Fri May 14 17:39:59 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D48A2106566B; Fri, 14 May 2010 17:39:59 +0000 (UTC) (envelope-from alc@cs.rice.edu) Received: from mail.cs.rice.edu (mail.cs.rice.edu [128.42.1.31]) by mx1.freebsd.org (Postfix) with ESMTP id 8AE808FC1F; Fri, 14 May 2010 17:39:59 +0000 (UTC) Received: from mail.cs.rice.edu (localhost.localdomain [127.0.0.1]) by mail.cs.rice.edu (Postfix) with ESMTP id E10C12C2AAC; Fri, 14 May 2010 12:39:58 -0500 (CDT) X-Virus-Scanned: by amavis-2.4.0 at mail.cs.rice.edu Received: from mail.cs.rice.edu ([127.0.0.1]) by mail.cs.rice.edu (mail.cs.rice.edu [127.0.0.1]) (amavisd-new, port 10024) with LMTP id PJCCPEk0FXfg; Fri, 14 May 2010 12:39:51 -0500 (CDT) Received: from [172.24.99.75] (unknown [192.75.139.249]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.cs.rice.edu (Postfix) with ESMTP id CE6082C2A81; Fri, 14 May 2010 12:39:50 -0500 (CDT) Message-ID: <4BED8ADE.1030100@cs.rice.edu> Date: Fri, 14 May 2010 12:39:42 -0500 From: Alan Cox User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.1.9) Gecko/20100317 Thunderbird/3.0.4 MIME-Version: 1.0 To: Benjamin Kaduk References: <20100514053907.GL83316@deviant.kiev.zoral.com.ua> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Kostik Belousov , alc@freebsd.org, freebsd-current@freebsd.org, attilio@freebsd.org Subject: Re: kgdb unuseable with cores on current (for some people) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 May 2010 17:39:59 -0000 On 5/14/2010 1:44 AM, Benjamin Kaduk wrote: > On Fri, 14 May 2010, Kostik Belousov wrote: > >> On Fri, May 14, 2010 at 12:55:35AM -0400, Benjamin Kaduk wrote: >>> Hi all, >>> >>> As was revealed in a recent thread here [1], several people have been >>> unable to use kgdb on coredumps for the past few months (but >>> possibly not >>> everyone). >>> >>> I am one of those affected, and have narrowed the breakage with a >>> binary >>> search to between SVN revisions 202883 and 202954 (that is, Jan 23 >>> 1200h >>> and Jan 25 0000h). Looking at the changes, alc's revision 202897 and >>> attilio's revision 202933 look to be the most plausible culprits in >>> terms >>> of what they touched. I will continue with my bisection, but with >>> only 36 >>> revisions in play, it is probably worth looking for the bug in parallel >>> with the bisection. >> >> Try reverting r202897 on fresh HEAD. I very much doubt that r202933 >> can be responsible. >> > > Indeed, 202933 was cleared of blame in the latest bisection. I'm > currently pulling up to HEAD and will try reverting 202897. I suspect the following is needed: Index: vm/vm_page.c =================================================================== --- vm/vm_page.c (revision 207823) +++ vm/vm_page.c (working copy) @@ -108,6 +108,7 @@ __FBSDID("$FreeBSD$"); #include #include #include +#include #include #include #include @@ -375,6 +376,14 @@ vm_page_startup(vm_offset_t vaddr) new_end + vm_page_dump_size, VM_PROT_READ | VM_PROT_WRITE); bzero((void *)vm_page_dump, vm_page_dump_size); #endif +#ifdef __amd64__ + pa = DMAP_TO_PHYS((vm_offset_t)msgbufp); + last_pa = pa + round_page(MSGBUF_SIZE); + while (pa < last_pa) { + dump_add_page(pa); + pa += PAGE_SIZE; + } +#endif /* * Compute the number of pages of memory that will be available for * use (taking into account the overhead of a page structure per