From owner-freebsd-ports-bugs@FreeBSD.ORG Mon May 6 15:20:02 2013 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 6DBF7289 for ; Mon, 6 May 2013 15:20:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 45F41C01 for ; Mon, 6 May 2013 15:20:02 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.6/8.14.6) with ESMTP id r46FK2vd075738 for ; Mon, 6 May 2013 15:20:02 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.6/8.14.6/Submit) id r46FK2eG075737; Mon, 6 May 2013 15:20:02 GMT (envelope-from gnats) Date: Mon, 6 May 2013 15:20:02 GMT Message-Id: <201305061520.r46FK2eG075737@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org Cc: From: Gang Hu Subject: Re: ports/178269: [PATCH] Remove checks for get_pidfile_from_conf function X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: Gang Hu List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 May 2013 15:20:02 -0000 The following reply was made to PR ports/178269; it has been noted by GNATS. From: Gang Hu To: Chris Rees Cc: jarrod@downtools.com.au, Florian Smeets , "bug-followup@freebsd.org" Subject: Re: ports/178269: [PATCH] Remove checks for get_pidfile_from_conf function Date: Mon, 6 May 2013 11:17:58 -0400 --14dae9340ff5e4162804dc0e35c8 Content-Type: text/plain; charset=ISO-8859-1 I'm fine with the get_pidfile_from_conf change. But I'm not sure whether the style changes are needed. For the quotes, with a quick grep in /etc/rc.d, it seems like that the standard ones have them. Maybe better leave them as-is. On Tue, Apr 30, 2013 at 5:52 PM, Chris Rees wrote: > Hi Jarrod, Florian and Henry, > > Please take note of ports/178269, containing a totally trivial change > to the rc scripts of net-mgmt/nrpe2, sysutils/munin-node and x11/slim. > > I'm trying to reduce the apparent fear around the use of > get_pidfile_from_conf, so this simplification should help. > > Are the changes OK with you? > > Chris > -- Cheers, Henry --14dae9340ff5e4162804dc0e35c8 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
I'm fine with the get_pidfile_from_conf change. But I&= #39;m not sure whether the style changes are needed.
For the quotes, wit= h a quick grep in /etc/rc.d, it seems like that the standard ones have them= . Maybe better leave them as-is.


On Tue,= Apr 30, 2013 at 5:52 PM, Chris Rees <utisoft@gmail.com> wro= te:
Hi Jarrod, Florian and Henry,

Please take note of ports/178269, containing a totally trivial change
to the rc scripts of net-mgmt/nrpe2, sysutils/munin-node and x11/slim.

I'm trying to reduce the apparent fear around the use of
get_pidfile_from_conf, so this simplification should help.

Are the changes OK with you?

Chris



--
Cheers,Henry
--14dae9340ff5e4162804dc0e35c8--