From owner-freebsd-amd64@FreeBSD.ORG Tue Jan 9 17:22:19 2007 Return-Path: X-Original-To: freebsd-amd64@freebsd.org Delivered-To: freebsd-amd64@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 13F9C16A407; Tue, 9 Jan 2007 17:22:19 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.freebsd.org (Postfix) with ESMTP id B1DD313C468; Tue, 9 Jan 2007 17:22:18 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id l09HM8sS077062; Tue, 9 Jan 2007 12:22:14 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: Bruce Evans Date: Tue, 9 Jan 2007 11:51:16 -0500 User-Agent: KMail/1.9.1 References: <1168211205.22629.6.camel@lanshark.dmv.com> <20070108154433.C75042@delplex.bde.org> In-Reply-To: <20070108154433.C75042@delplex.bde.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200701091151.17166.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Tue, 09 Jan 2007 12:22:15 -0500 (EST) X-Virus-Scanned: ClamAV 0.88.3/2429/Tue Jan 9 09:23:53 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: rwatson@freebsd.org, freebsd-amd64@freebsd.org Subject: Re: Panic in 6.2-PRERELEASE with bge on amd64 X-BeenThere: freebsd-amd64@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to the AMD64 platform List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jan 2007 17:22:19 -0000 On Monday 08 January 2007 00:06, Bruce Evans wrote: > On Sun, 7 Jan 2007, Sven Willenberger wrote: > > > I am starting a new thread on this as what I had assumed was a panic in > > nfsd turns out to be an issue with the bge driver. This is an amd64 box, > > dual processor (SMP kernel) that happens to be running nfsd. About every > > 3-5 days the kernel panics and I have finally managed to get a core > > dump. > > The system: FreeBSD 6.2-PRERELEASE #8: Tue Jan 2 10:57:39 EST 2007 > > Like most NIC drivers, bge unlocks and re-locks around its call to > ether_input() in its interrupt handler. This isn't very safe, and it > certainly causes panics for bge. I often see it panic when bringing > the interface down and up while input is arriving, on a non-SMP non-amd64 > (actually i386) non-6.x (actually -current) system. Bringing the > interface down is probably the worst case. It creates a null pointer > for bge_intr() to follow. Why do you feel that it is unsafe to drop the lock around if_input()? -- John Baldwin