From owner-svn-src-head@FreeBSD.ORG Tue Jun 25 18:36:50 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 6B54261E; Tue, 25 Jun 2013 18:36:50 +0000 (UTC) (envelope-from slw@zxy.spb.ru) Received: from zxy.spb.ru (zxy.spb.ru [195.70.199.98]) by mx1.freebsd.org (Postfix) with ESMTP id 2A1F81CDB; Tue, 25 Jun 2013 18:36:50 +0000 (UTC) Received: from slw by zxy.spb.ru with local (Exim 4.69 (FreeBSD)) (envelope-from ) id 1UrY7f-000LRf-Rk; Tue, 25 Jun 2013 22:37:47 +0400 Date: Tue, 25 Jun 2013 22:37:47 +0400 From: Slawa Olhovchenkov To: Adrian Chadd Subject: Re: svn commit: r252184 - head/sys/net Message-ID: <20130625183747.GJ58171@zxy.spb.ru> References: <201306250010.r5P0Aosi087956@svn.freebsd.org> <20130625134858.GA61858@zxy.spb.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: slw@zxy.spb.ru X-SA-Exim-Scanned: No (on zxy.spb.ru); SAEximRunCond expanded to false Cc: svn-src-head@freebsd.org, Qing Li , svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Jun 2013 18:36:50 -0000 On Tue, Jun 25, 2013 at 11:33:31AM -0700, Adrian Chadd wrote: > Is this worth a freebsd version bump? In case some ports rely on the > new-but-now-broken behaviour? I think bird reinstall routes w/o RTF_GATEWAY bit and can't remove this. I think none relay on returned routes w/o RTF_GATEWAY bit. > Adrian > > On 25 June 2013 06:48, Slawa Olhovchenkov wrote: > > On Tue, Jun 25, 2013 at 12:10:50AM +0000, Qing Li wrote: > > > >> Author: qingli > >> Date: Tue Jun 25 00:10:49 2013 > >> New Revision: 252184 > >> URL: http://svnweb.freebsd.org/changeset/base/252184 > >> > >> Log: > >> Due to the routing related networking kernel redesign work > >> in FBSD 8.0, interface routes have been returened to the > >> applications without the RTF_GATEWAY bit. This incompatibility > >> has caused some issues with Zebra, Qugga and the like. > >> This patch provides the RTF_GATEWAY flag bit in returned interface > >> routes so to behave similarly to pre 8.0 systems. > >> > >> Reviewed by: hrs > >> Verified by: mackn at opendns dot com > >> > >> Modified: > >> head/sys/net/route.h > >> head/sys/net/rtsock.c > > > > MFC planed?