Date: Sat, 2 Sep 2017 10:33:19 +0930 From: Shane Ambler <FreeBSD@ShaneWare.Biz> To: Yuri <yuri@rawbw.com>, Tobias Kortkamp <tobik@freebsd.org>, ports@freebsd.org Subject: Re: Some github projects aren't fetchable using commit hash Message-ID: <c37d806c-f9d8-d0cb-4a55-5af9a0c5ea3b@ShaneWare.Biz> In-Reply-To: <4e2b7041-6ee3-6994-437d-39de395ffca3@rawbw.com> References: <aa643aff-e842-b50e-5ae5-06e6c084ed5b@rawbw.com> <1504284830.794543.1092454472.7353C7D3@webmail.messagingengine.com> <4e2b7041-6ee3-6994-437d-39de395ffca3@rawbw.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 02/09/2017 02:29, Yuri wrote: > On 09/01/17 09:53, Tobias Kortkamp wrote: >> In libretro/picodrive there are two objects which have the same >> abbreviated hash. Probably best to use the full hash. > > > Since another object with the same abbreviated hash can be committed > into the project any time, any port using such hash (which is a lot) can > break any time. I thought the porters handbook specified using a 10 digit hash... at the minimum you need a hash long enough that it is unique in that repo. If a later commit breaks the uniqueness then a longer hash will be needed. Respond to github support that an abbreviated hash with multiple matches will fail. Under that condition, it may be desirable to respond with the newest of the matches rather than a not found error. -- FreeBSD - the place to B...Software Developing Shane Ambler
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?c37d806c-f9d8-d0cb-4a55-5af9a0c5ea3b>