From owner-svn-src-head@FreeBSD.ORG Tue Sep 21 15:48:23 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D8D4E106567A; Tue, 21 Sep 2010 15:48:23 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-qw0-f54.google.com (mail-qw0-f54.google.com [209.85.216.54]) by mx1.freebsd.org (Postfix) with ESMTP id 288108FC26; Tue, 21 Sep 2010 15:48:22 +0000 (UTC) Received: by qwg5 with SMTP id 5so4961379qwg.13 for ; Tue, 21 Sep 2010 08:48:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:sender:received :in-reply-to:references:date:x-google-sender-auth:message-id:subject :from:to:cc:content-type; bh=ls+dToSLXVfuAz7a+c2dZYvjxWv5dxXwEoW5UkbnFpM=; b=fatzqq8ZLXE+Q2eMLeq6ZKrlM9h4ECazy21MQWA8gvlRszHULFMz6Vsu4LQpdlA43B Yr/JQLtYFXaxSOuRoSKQqFrRVbkTDiQTEQYR+S8Y9mLW+K5EnPE6KnqUjVd5UW/Bl6Lx EQFZZZ5q3M5yZ+wH37zkMeRqNNTcgX1tQ/3Ps= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; b=eHqGBpBjjs8Vn2f3EhtbPePrXzKU9E6HMgnpAifPI6S+TXLf7p5MuHbey7MX//qYxm QW4iI5zGJm+sFuW2lyCPl5/mlqfLooxejCsXbQKTTdw0Q50/mGpNb8ia3dCyy1HW7a6N 4wvcDOy62hNXJnqA7LcK+bmgGAz12bW13uDWk= MIME-Version: 1.0 Received: by 10.224.19.205 with SMTP id c13mr697474qab.63.1285084101966; Tue, 21 Sep 2010 08:48:21 -0700 (PDT) Sender: asmrookie@gmail.com Received: by 10.229.235.143 with HTTP; Tue, 21 Sep 2010 08:48:21 -0700 (PDT) In-Reply-To: <4C98D200.4040909@freebsd.org> References: <201009211507.o8LF7iVv097676@svn.freebsd.org> <4C98CEE7.6060802@freebsd.org> <4C98D200.4040909@freebsd.org> Date: Tue, 21 Sep 2010 17:48:21 +0200 X-Google-Sender-Auth: Z0xkzM2JKhf6IagNM-lheL6zy94 Message-ID: From: Attilio Rao To: Andriy Gapon Content-Type: text/plain; charset=UTF-8 Cc: svn-src-head@freebsd.org, mdf@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r212964 - head/sys/kern X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Sep 2010 15:48:24 -0000 2010/9/21 Andriy Gapon : > on 21/09/2010 18:27 Andriy Gapon said the following: >> on 21/09/2010 18:17 mdf@FreeBSD.org said the following: >>> >>> I'd recommend using stack_print_ddb(), as that avoids any locking >>> which may hang depending on how the kernel panic'd. >> >> It seems that stack_print_ddb() depends on DDB? > > But the point about locking is very good. > How do you suggest we can deal with it? > > A dirty hack would be to check panicstr in linker_search_symbol_name and avoid > locking, but I don't like that at all. > Perhaps, some code in subr_stack.c could be taken outside DDB ifdef? It heavilly depends on DDB, I'd say to just leave as the code is now. Thanks, Attilio -- Peace can only be achieved by understanding - A. Einstein