Date: Tue, 19 Apr 2005 14:08:28 +0200 From: Andre Oppermann <andre@freebsd.org> To: Gleb Smirnoff <glebius@FreeBSD.org> Cc: net@FreeBSD.org Subject: Re: if_link_state_change() patch for review Message-ID: <4264F4BC.4F3B57AE@freebsd.org> References: <20050419064747.GC734@cell.sick.ru> <4264D430.D39B81D0@freebsd.org> <20050419120324.GA5862@cell.sick.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
Gleb Smirnoff wrote: > A> You have to be careful here indeed. If the link is rapidly flapping > A> then you only want to report changes in status. For example when > A> it going down, up, down and all these events got queued it doesn't > A> make sense to report down->down. This could indeed confuse some > A> tools and isn't very useful. Either you check the first event vs. > A> the last one if there is a change in state or you just take the events > A> as trigger to have a look at the interface status when the ithread > A> runs. There however you'd have to track the previous state to detect > A> changes. > > I do not know any applications which would be confused, yet. Also, while > event coalescing is possible theoretically, I failed to reproduce it. I've > added a debugging printf, so we will see if anyone experiences these > coalescing events at all. It doesn't really make sense, so we better don't do it and document that fact. -- Andre
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4264F4BC.4F3B57AE>