From nobody Fri Oct 1 13:44:09 2021 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 169DB17EEDC3 for ; Fri, 1 Oct 2021 13:44:09 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HLWYP013Nz4S4h for ; Fri, 1 Oct 2021 13:44:09 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id D499A208CE for ; Fri, 1 Oct 2021 13:44:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 191Di8Eg059114 for ; Fri, 1 Oct 2021 13:44:08 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 191Di8tm059113 for bugs@FreeBSD.org; Fri, 1 Oct 2021 13:44:08 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 258845] iflib: error from IFDI_PROMISC_SET() not handled Date: Fri, 01 Oct 2021 13:44:09 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: emaste@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D258845 Bug ID: 258845 Summary: iflib: error from IFDI_PROMISC_SET() not handled Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: emaste@freebsd.org iflib_if_ioctl has: 4360 case SIOCSIFFLAGS: 4361 CTX_LOCK(ctx); 4362 if (if_getflags(ifp) & IFF_UP) { 4363 if (if_getdrvflags(ifp) & IFF_DRV_RUNNING) { 4364 if ((if_getflags(ifp) ^ ctx->ifc_if_flags) & 4365 (IFF_PROMISC | IFF_ALLMULTI)) { 4366 CTX_UNLOCK(ctx); 4367 err =3D IFDI_PROMISC_SET(ct= x, if_getflags(ifp)); 4368 CTX_LOCK(ctx); 4369 } 4370 } else 4371 reinit =3D 1; 4372 } else if (if_getdrvflags(ifp) & IFF_DRV_RUNNING) { 4373 iflib_stop(ctx); 4374 } 4375 ctx->ifc_if_flags =3D if_getflags(ifp); 4376 CTX_UNLOCK(ctx); 4377 break; Note that ctx->ifc_if_flags is set regardless of error return from IFDI_PROMISC_SET(). Assume that IFDI_PROMISC_SET() fails for some reason. A subsequent SIOCSIFFLAGS call to set promisc or allmulti should result in another IFDI_PROMISC_SET() call but will be skipped due to the comparison = at line 4364. --=20 You are receiving this mail because: You are the assignee for the bug.=