From owner-freebsd-stable Wed Jul 3 10:56:15 2002 Delivered-To: freebsd-stable@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 04F2637B400; Wed, 3 Jul 2002 10:56:12 -0700 (PDT) Received: from apollo.backplane.com (apollo.backplane.com [216.240.41.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id E853043E4A; Wed, 3 Jul 2002 10:56:10 -0700 (PDT) (envelope-from dillon@apollo.backplane.com) Received: from apollo.backplane.com (localhost [127.0.0.1]) by apollo.backplane.com (8.12.4/8.12.3) with ESMTP id g63HuAT4013424; Wed, 3 Jul 2002 10:56:10 -0700 (PDT) (envelope-from dillon@apollo.backplane.com) Received: (from dillon@localhost) by apollo.backplane.com (8.12.4/8.12.3/Submit) id g63HuAlp013423; Wed, 3 Jul 2002 10:56:10 -0700 (PDT) (envelope-from dillon) Date: Wed, 3 Jul 2002 10:56:10 -0700 (PDT) From: Matthew Dillon Message-Id: <200207031756.g63HuAlp013423@apollo.backplane.com> To: Dag-Erling Smorgrav Cc: Garance A Drosihn , Adrian Penisoara , freebsd-stable@FreeBSD.ORG, bde@FreeBSD.ORG, obrien@FreeBSD.ORG, dillon@FreeBSD.ORG Subject: Re: __FBSDID breaks buildworld upgrading References: Sender: owner-freebsd-stable@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG You beat me to it, I was just about to comment that a better way would be to do the equivalent #define __FBSDID() to empty on the command line as part of the build process. __FBSDID() exists in part to avoid having to have #ifdef's all over the place. -Matt Matthew Dillon :Garance A Drosihn writes: :> We talk about providing support for older releases of FreeBSD, but :> here we are moving to a world where EVERY SINGLE SOURCE FILE in :> the systsem will need some kind of futzing around with to compile :> it on systems which are just 9 months old (as it looks like __FBSDID :> was MFC'ed into -stable on Sept 28, 2001). : :Actually, no. I've backed out my commit and made a different commit :to bsd.sys.mk that solves this in a generic way. : :> I really do not mean this as an insult to anyone, but I think we :> are so fascinated with the few real advantages of __FBSDID (such :> as getting the RCS-ids into a separate ELF section) that we are :> sinking far too much effort into trying to make it work. Are :> the benefits really worth all that effort? : :Yes. Amongst other things, it allows people to easily determine what :sources a particular binary or library was built from, which again :allows admins to make much more informed decisions about potential :security vulnerabilities in their systems. It also helps debug :problems reported by inexperienced users. : :DES :-- :Dag-Erling Smorgrav - des@ofug.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message