From owner-cvs-all@FreeBSD.ORG  Sun Apr  4 20:55:28 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id C9AD116A4CF
	for <cvs-all@FreeBSD.org>; Sun,  4 Apr 2004 20:55:28 -0700 (PDT)
Received: from root.org (root.org [67.118.192.226])
	by mx1.FreeBSD.org (Postfix) with SMTP id 90E2143D5A
	for <cvs-all@FreeBSD.org>; Sun,  4 Apr 2004 20:55:28 -0700 (PDT)
	(envelope-from nate@root.org)
Received: (qmail 17661 invoked by uid 1000); 5 Apr 2004 03:55:30 -0000
Date: Sun, 4 Apr 2004 20:55:30 -0700 (PDT)
From: Nate Lawson <nate@root.org>
To: Jeff Roberson <jeff@FreeBSD.org>
In-Reply-To: <20040404191311.44B1916A4E9@hub.freebsd.org>
Message-ID: <20040404205507.T17609@root.org>
References: <20040404191311.44B1916A4E9@hub.freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/kern sched_ule.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Apr 2004 03:55:29 -0000

On Sun, 4 Apr 2004, Jeff Roberson wrote:
>   Modified files:
>     sys/kern             sched_ule.c
>   Log:
>    - Use the proper constant in sched_interact_update().  Previously,
>      SCHED_INTERACT_MAX was used where SCHED_SLP_RUN_MAX was needed.  This was
>      causing the interactivity scaler to lose history at a more dramatic rate
>      than intended.
>
>   Revision  Changes    Path
>   1.103     +1 -1      src/sys/kern/sched_ule.c
>
>
> --- src/sys/kern/sched_ule.c:1.102	Sat Mar 27 10:21:24 2004
> +++ src/sys/kern/sched_ule.c	Sun Apr  4 12:12:56 2004
> @@ -1043,7 +1043,7 @@
>  	 * will not bring us back into range.  Dividing by two here forces
>  	 * us into the range of [3/5 * SCHED_INTERACT_MAX, SCHED_INTERACT_MAX]
>  	 */
> -	if (sum > (SCHED_INTERACT_MAX / 5) * 6) {
> +	if (sum > (SCHED_SLP_RUN_MAX / 5) * 6) {
>  		kg->kg_runtime /= 2;
>  		kg->kg_slptime /= 2;
>  		return;

It seems the comment is now out of synch.

-Nate