From owner-freebsd-geom@FreeBSD.ORG Mon Jan 26 07:53:15 2004 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8FD3516A4CE for ; Mon, 26 Jan 2004 07:53:15 -0800 (PST) Received: from mailbox.univie.ac.at (mailbox.univie.ac.at [131.130.1.27]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8756C43D90 for ; Mon, 26 Jan 2004 07:52:17 -0800 (PST) (envelope-from l.ertl@univie.ac.at) Received: from pcle2.cc.univie.ac.at (pcle2.cc.univie.ac.at [131.130.2.177]) i0QFocL9337626; Mon, 26 Jan 2004 16:50:41 +0100 Date: Mon, 26 Jan 2004 16:50:38 +0100 (CET) From: Lukas Ertl To: Pawel Jakub Dawidek In-Reply-To: <20040125234848.GH565@garage.freebsd.pl> Message-ID: <20040126164924.C90355@pcle2.cc.univie.ac.at> References: <20040125234848.GH565@garage.freebsd.pl> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-DCC-ZID-Univie-Metrics: imap 4245; Body=0 Fuz1=0 Fuz2=0 cc: freebsd-geom@freebsd.org Subject: Re: Preventing deadlocks on the event queue. X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Jan 2004 15:53:15 -0000 On Mon, 26 Jan 2004, Pawel Jakub Dawidek wrote: > Hello. > > So, I think I've found clever way to prevents deadlock caused by > calling g_waitfor_event() from an event. > > My idea is to check if curthread in g_waitfor_event() is a g_event thread. > > http://garage.freebsd.pl/patches/geom_event_deadlock.patch Do you really want to make this a separate function? Since it's just a one-line comparison, wouldn't a macro suffice? regards, le -- Lukas Ertl eMail: l.ertl@univie.ac.at UNIX Systemadministrator Tel.: (+43 1) 4277-14073 Vienna University Computer Center Fax.: (+43 1) 4277-9140 University of Vienna http://mailbox.univie.ac.at/~le/