From owner-cvs-src@FreeBSD.ORG  Wed Jun 21 17:44:04 2006
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id E9E8116A47B;
	Wed, 21 Jun 2006 17:44:04 +0000 (UTC) (envelope-from alc@cs.rice.edu)
Received: from mail.cs.rice.edu (mail.cs.rice.edu [128.42.1.31])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 88E9643D48;
	Wed, 21 Jun 2006 17:44:04 +0000 (GMT) (envelope-from alc@cs.rice.edu)
Received: from mail.cs.rice.edu (localhost.localdomain [127.0.0.1])
	by mail.cs.rice.edu (Postfix) with ESMTP id D83CD2C2C89;
	Wed, 21 Jun 2006 12:44:03 -0500 (CDT)
X-Virus-Scanned: by amavis-2.4.0 at mail.cs.rice.edu
Received: from mail.cs.rice.edu ([127.0.0.1])
	by mail.cs.rice.edu (mail.cs.rice.edu [127.0.0.1]) (amavisd-new,
	port 10024)
	with LMTP id e-l+GWxUu001; Wed, 21 Jun 2006 12:44:03 -0500 (CDT)
Received: from [216.63.78.18] (adsl-216-63-78-18.dsl.hstntx.swbell.net
	[216.63.78.18])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mail.cs.rice.edu (Postfix) with ESMTP id D53A02C2C61;
	Wed, 21 Jun 2006 12:44:02 -0500 (CDT)
Message-ID: <44998562.6080705@cs.rice.edu>
Date: Wed, 21 Jun 2006 12:44:02 -0500
From: Alan Cox <alc@cs.rice.edu>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.10) Gecko/20050817
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: John-Mark Gurney <gurney_j@resnet.uoregon.edu>
References: <200606211259.k5LCx5as082227@repoman.freebsd.org>
	<20060621172849.GA82074@funkthat.com>
In-Reply-To: <20060621172849.GA82074@funkthat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org,
	Konstantin Belousov <kib@FreeBSD.org>, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/lib/libc/sys mincore.2 src/sys/vm vm_mmap.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Jun 2006 17:44:05 -0000

John-Mark Gurney wrote:

>Konstantin Belousov wrote this message on Wed, Jun 21, 2006 at 12:59 +0000:
>  
>
>>  Modified files:
>>    lib/libc/sys         mincore.2 
>>    sys/vm               vm_mmap.c 
>>  Log:
>>  Make the mincore(2) return ENOMEM when requested range is not fully mapped.
>>    
>>
>
>Is this change to be posix compliant or something?  ENOMEM seems like
>the wrong error, or are we allocating memory?
>#define ENOMEM          12              /* Cannot allocate memory */
>
>the original EINVAL seems to me the correct one, as is commonly used
>when the data passed in is incorrect...
>
>  
>
I looked at this when the patch was proposed.  ENOMEM is the de facto 
standard error for this case.  To the best of my knowledge, there is no 
officially-sanctioned specification for mincore(2).

Regards,
Alan