From owner-svn-src-all@freebsd.org Sun Aug 14 06:06:42 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1B881BB9B06; Sun, 14 Aug 2016 06:06:42 +0000 (UTC) (envelope-from gjb@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 095D1125E; Sun, 14 Aug 2016 06:06:42 +0000 (UTC) (envelope-from gjb@FreeBSD.org) Received: from FreeBSD.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by freefall.freebsd.org (Postfix) with ESMTP id 9609B1C50; Sun, 14 Aug 2016 06:06:41 +0000 (UTC) (envelope-from gjb@FreeBSD.org) Date: Sun, 14 Aug 2016 06:06:39 +0000 From: Glen Barber To: Conrad Meyer Cc: Juli Mallett , src-committers , svn-src-all@freebsd.org, svn-src-svnadmin@freebsd.org, svnadm@freebsd.org Subject: Re: svn commit: r304070 - svnadmin/conf Message-ID: <20160814060639.GG11079@FreeBSD.org> References: <201608140435.u7E4Z4Fm022554@repo.freebsd.org> <20160814044723.GF11079@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="GN/IAAAoV4GJoJGS" Content-Disposition: inline In-Reply-To: X-Operating-System: FreeBSD 11.0-CURRENT amd64 X-SCUD-Definition: Sudden Completely Unexpected Dataloss X-SULE-Definition: Sudden Unexpected Learning Event X-PEKBAC-Definition: Problem Exists, Keyboard Between Admin/Computer User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Aug 2016 06:06:42 -0000 --GN/IAAAoV4GJoJGS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Aug 13, 2016 at 10:51:59PM -0700, Conrad Meyer wrote: > On Sat, Aug 13, 2016 at 10:48 PM, Juli Mallett = wrote: > > On Sat, Aug 13, 2016 at 9:47 PM, Glen Barber wrote: > >> Quoting the original request to remove this, which I tend to agree: > >> > >> -------------------------- begin quoted text -------------------------= -- > >> The svn commit mail script uses some form of 'diff -p' (or 'svn diff > >> -x-p') to include function names at the top of each hunk. The problem > >> is that diff gets it wrong more often than not, especially (but not > >> only) when functions are added or renamed, or outside a funciton, or = in > >> headers, or in code that makes heavy use of macros, or in files that > >> aren't C-like source code: shell scripts, man pages, Makefiles... All > >> it really does is clutter up the patch and mislead the reader. > >> --------------------------- end quoted text --------------------------= -- > > > > :( > > > > I'm deeply skeptical that the described conditions add up to "more > > often than not," and that tangible harm is done in those cases, > > outweighing benefit added in the other, ostensibly rarer, case > > (changes in ordinary C source files, which are actually fairly > > abundant in FreeBSD.) >=20 > Exactly. Yes, it gets it wrong sometimes. But not enough to make it > more harmful than beneficial. >=20 Reverted. I won't deal with this topic further. Glen --GN/IAAAoV4GJoJGS Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXsApvAAoJEAMUWKVHj+KTGHwP/14XNX/9qwt5ZV6YRJA3JywA DvztMwltIvKI7G3ki5ZEwouOR40e+Mq57cAfVVlQVCY56wckflQoOdIyWi+KW26W b2WxQ5ZZApZYSRw2KPYJcL9i7fxih5sbE+pfJq77WOj9Uze7jQ1CblLHavFwTjee VGe+ePH5uGNUY0KBfgmR0SHgrGWWzS8SHB2GIZzG9CPnqGLkfaSdeMlBMcw9CBc1 1asX+1HkiN4B0oogCnYQSWcLsNCl5BhDhG3gtZxSfssxJZnh4qxND9x29wKKaZsz NiUYylpYWFJ3Ub39Aq4SB7tYmx4uLGI3gctyolp3tkAhcT3MVNgBFX/5uF1rSjaF QTBKqOQNTr5/nhWtCD3SQ07cm7SEnhK2ig87WL+V+vUr0xtbIVcGrYVObFWTKM/N ruGXidTO2rywkWxUqTdn5tiREe3bTAGHKhrkXSGSywhzo1p6fEMThLpf6Ytce+Pe 9x5JqIQERvNClisQjSyBRkxk0H1V5WXFKtdxu/jPHWlzT0TEPNLCvpv+Temhgtmi Yc1EbqdbRvynwfq2FIOKsr+cEx2DjgrCYRiL24p7JnQnOmNb6qVyI8Zy9HyGs2zg oLscvU+oWqUMQSWzkZmo4I3i8wqC4dQZssyDX4Vj8EUkqkqSbdf0/oRcrPYXeCgc sqDvZuU5pL3zjWKBr9kq =ah93 -----END PGP SIGNATURE----- --GN/IAAAoV4GJoJGS--