From owner-svn-src-stable@freebsd.org Wed Dec 14 15:42:54 2016 Return-Path: Delivered-To: svn-src-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DE41FC80DC1; Wed, 14 Dec 2016 15:42:54 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citapm.icyb.net.ua (citapm.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 626A785D; Wed, 14 Dec 2016 15:42:46 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citapm.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id RAA21043; Wed, 14 Dec 2016 17:42:45 +0200 (EET) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1cHBhd-0002GJ-Aw; Wed, 14 Dec 2016 17:42:45 +0200 Subject: Re: svn commit: r308371 - in stable/10: share/man/man4 sys/conf sys/dev/jedec_ts sys/modules/i2c sys/modules/i2c/jedec_ts To: John Baldwin References: <201611061356.uA6DuYcO079294@repo.freebsd.org> <1625245.4edrXav981@ralph.baldwin.cx> Cc: src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-stable@FreeBSD.org, svn-src-stable-10@FreeBSD.org From: Andriy Gapon Message-ID: <912ba7fd-353c-006e-ef65-faa12b83de9f@FreeBSD.org> Date: Wed, 14 Dec 2016 17:41:47 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1625245.4edrXav981@ralph.baldwin.cx> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Dec 2016 15:42:55 -0000 On 05/12/2016 23:49, John Baldwin wrote: > On Sunday, November 06, 2016 01:56:34 PM Andriy Gapon wrote: >> Author: avg >> Date: Sun Nov 6 13:56:34 2016 >> New Revision: 308371 >> URL: https://svnweb.freebsd.org/changeset/base/308371 >> >> Log: >> MFC r307768: jedec_ts: a driver for thermal sensors on memory modules >> >> Added: >> stable/10/share/man/man4/jedec_ts.4 >> - copied unchanged from r307768, head/share/man/man4/jedec_ts.4 >> stable/10/sys/dev/jedec_ts/ >> - copied from r307768, head/sys/dev/jedec_ts/ >> stable/10/sys/modules/i2c/jedec_ts/ >> - copied from r307768, head/sys/modules/i2c/jedec_ts/ >> Modified: >> stable/10/sys/conf/NOTES >> stable/10/sys/conf/files >> stable/10/sys/modules/i2c/Makefile >> Directory Properties: >> stable/10/ (props changed) > > FYI, this doesn't work and has broken tinderbox builds on stable/10. > smbus_get_addr() doesn't exist on 10. It was originally a hand-rolled > ivar wrapper that was removed in r93023 in 2002. The function prototype > was not removed, so the compile works, but linking fails. The stale > prototype is still present in smbconf.h in HEAD (and should be removed). > The "real" smbus_get_addr() was added back to smbconf.h along with an > implementation of smbus_read_ivar() in r281985. Parts of that commit > probably need to be MFC'd to 10. > John, thank you for catching this and sorry for the trouble. Could you please check if r310062 really fixes the problem? -- Andriy Gapon