From owner-freebsd-net Tue Jan 14 3:45: 6 2003 Delivered-To: freebsd-net@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BC38A37B401 for ; Tue, 14 Jan 2003 03:45:04 -0800 (PST) Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by mx1.FreeBSD.org (Postfix) with SMTP id A963743F3F for ; Tue, 14 Jan 2003 03:45:02 -0800 (PST) (envelope-from tmoestl@gmx.net) Received: (qmail 26740 invoked by uid 0); 14 Jan 2003 11:45:00 -0000 Received: from p508e5426.dip.t-dialin.net (HELO galatea.local) (80.142.84.38) by mail.gmx.net (mp018-rz3) with SMTP; 14 Jan 2003 11:45:00 -0000 Received: from localhost ([127.0.0.1] helo=galatea.local) by galatea.local with esmtp (Exim 4.12 #1) id 18YPWg-0000OH-00; Tue, 14 Jan 2003 12:46:38 +0100 Received: (from tmm@localhost) by galatea.local (8.12.6/8.12.6/Submit) id h0EBkWwu001504; Tue, 14 Jan 2003 12:46:32 +0100 (CET) Date: Tue, 14 Jan 2003 12:46:32 +0100 From: Thomas Moestl To: Terry Lambert Cc: Martin Blapp , current@freebsd.org, net@freebsd.org Subject: Re: PANIC in tcp_syncache.c sonewconn() line 562 Message-ID: <20030114114632.GA280@crow.dom2ip.de> Mail-Followup-To: Terry Lambert , Martin Blapp , current@freebsd.org, net@freebsd.org References: <20030113173957.T73725@levais.imp.ch> <20030113215318.GA278@crow.dom2ip.de> <20030114100620.W76016@levais.imp.ch> <3E23EB97.694EC9BB@mindspring.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3E23EB97.694EC9BB@mindspring.com> User-Agent: Mutt/1.4i Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org On Tue, 2003/01/14 at 02:51:03 -0800, Terry Lambert wrote: > Martin Blapp wrote: > > Can you commit this ? The fix looks appropriate, but the manpage should > > also be changed to reflect the change. > > > > ERRORS > > Listen() will fail if: > > > > [EBADF] The argument s is not a valid descriptor. > > [ENOTSOCK] The argument s is not a socket. > > [EOPNOTSUPP] The socket is not of a type that > > supports the operation listen(). > > [EINVAL] Listen() has been already called on the socket. > > > > Any objections from others ? > > It seems to me that calling listen() on a socket to change the > listen queue depth is a reasonable thing to do; this is true > before it's bound, after it's bound, before listen() has been > called on it, and after listen() has been called on it once (or > more). > > Am I missing something here? Is there a good technical reason > to not permit an application to change the listen queue depth? > Or is there some way that an application can do this, using a > call other than listen()? > > That it causes a panic when the SYN cache is enabled isn't really > a technical reason, it's a circumstantial reason. The manpage change does not reflect the change in the patch :) It should be: [EINVAL] The socket is connected. - Thomas -- Thomas Moestl http://www.tu-bs.de/~y0015675/ http://people.FreeBSD.org/~tmm/ PGP fingerprint: 1C97 A604 2BD0 E492 51D0 9C0F 1FE6 4F1D 419C 776C To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message