From owner-freebsd-ports-bugs@freebsd.org Tue Aug 23 01:15:23 2016 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D431DBC023E for ; Tue, 23 Aug 2016 01:15:23 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A8BE9150A for ; Tue, 23 Aug 2016 01:15:23 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u7N1FM34026739 for ; Tue, 23 Aug 2016 01:15:23 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 209742] devel/godot: Update to 2.1; add devel/godot-tools port Date: Tue, 23 Aug 2016 01:15:21 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: feature, patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: lightside@gmx.com X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback+ X-Bugzilla-Changed-Fields: flagtypes.name attachments.isobsolete attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Aug 2016 01:15:23 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D209742 lightside changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173942|maintainer-approval?(FreeBS | Flags|D@ShaneWare.Biz) | Attachment #173942|0 |1 is obsolete| | Attachment #173959| |maintainer-approval?(FreeBS Flags| |D@ShaneWare.Biz) --- Comment #79 from lightside --- Created attachment 173959 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D173959&action= =3Dedit Proposed patch (since 415742 revision) (In reply to comment #76) > OPTIONS_DEFAULT=3D OSS I noticed, that you proposed to remove "+=3D". This is ok, if there are no = other default option(s) used for devel/godot-tools port (The EXAMPLES option is n= ot affected). The removal of OPTIONS_DEFINE+=3DDEBUG (and related code) is not ok, because there is a target=3Ddebug option available, which maybe used for tools=3Dno= and tools=3Dyes options: https://github.com/godotengine/godot/blob/2.1-stable/SConstruct#L116 https://github.com/godotengine/godot/blob/2.1-stable/SConstruct#L181 https://github.com/godotengine/godot/blob/2.1-stable/SConstruct#L269 The "+=3D" used, because OPTIONS_DEFINE=3DEXAMPLES defined in devel/godot-t= ools port. --=20 You are receiving this mail because: You are the assignee for the bug.=