Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 30 Oct 2012 16:56:16 +0000 (UTC)
From:      Hans Petter Selasky <hselasky@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r242364 - head/sys/dev/usb
Message-ID:  <201210301656.q9UGuGKT033838@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: hselasky
Date: Tue Oct 30 16:56:16 2012
New Revision: 242364
URL: http://svn.freebsd.org/changeset/base/242364

Log:
  If a USB mass storage device doesn't respond properly
  to the initial SCSI INQUIRY command, enable all quirks.
  This fixes detection of some Transcend TS2GUFM devices.
  
  MFC after:	1 week
  Reported by:	Michael Dexter

Modified:
  head/sys/dev/usb/usb_msctest.c

Modified: head/sys/dev/usb/usb_msctest.c
==============================================================================
--- head/sys/dev/usb/usb_msctest.c	Tue Oct 30 15:25:23 2012	(r242363)
+++ head/sys/dev/usb/usb_msctest.c	Tue Oct 30 16:56:16 2012	(r242364)
@@ -664,8 +664,11 @@ usb_msc_auto_quirk(struct usb_device *ud
 			if (sid_type == 0x00)
 				is_no_direct = 0;
 			break;
-		} else if (err != ERR_CSW_FAILED)
-			break;	/* non retryable error */
+		} else if (err != ERR_CSW_FAILED) {
+			DPRINTF("Device is not responding "
+			    "properly to SCSI INQUIRY command.\n");
+			goto error;	/* non retryable error */
+		}
 		usb_pause_mtx(NULL, hz);
 	}
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201210301656.q9UGuGKT033838>