From nobody Thu Sep 7 17:31:40 2023 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RhRB431r5z4sKPk for ; Thu, 7 Sep 2023 17:31:40 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RhRB41s9Zz4Pfh for ; Thu, 7 Sep 2023 17:31:40 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1694107900; a=rsa-sha256; cv=none; b=vjH/R6GkOOceIAWC98BMc1RFKC6PwUobbzbpOq0gj4pAqfYl4dyxbaZvNCI37tZCeLZI9z oN/ENtbiLL+ItE22/6j2AhcJvqvFI4u7mSCE7GvPp2Pxl0yd0JqayIVWAZzIeSa1fZp9Ms T7YumhEB1jiQJCNVGf85rKA1emOpcT16tP95Dmq6qK2jBb5T9ZNCk53m7UPqYjjD8E6NK2 6bBF8mD7CYwWxgm4jAYpMOCEiJ2H0QCCW/RVZTWvIDmtloORd0tJJb7URrfTUfAot9h3Dr d7WlgwFMzZnkZqz2RoMV2SfPHZs7RDdFQ4OG01nzLawNvuKjJ831Io602gZvwg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1694107900; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Mw8TvHCbAE7uQmrOA22orqG1Zx7cw5wWAXxEUppVOCw=; b=L+Oq2Kn/RGHKxRVb2alO2shuAow34bec7/828lG07x5fQVjmtxhd8BAHmH+bLDG4Z4gyFX eSCJ6/CWKPd3YtAx7colg2BUueFWw4Ee4jawpXa+NFdvY+09LtcGBv6FZWik4MyMSFrS3O Q/f2eDdvaK9D5ybWhxpd4Yrc9pPts2J35BW2b6jyXaqg9NDZtI0N1gPCsF3abiApx+KJ8o agu1XUR/AWZxJqMzMMqhm9qLW+64Wk7xibvqBE5E8q6e6yoZjt6kS+lXv8lo3wagB4sc3l w6jcbb4yGu2K6u3R5Mq8KwTR9O8AFya+YljjtSeVYEmtX37DUjV0lARwDs8Ksg== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4RhRB40wwHz177c for ; Thu, 7 Sep 2023 17:31:40 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 387HVeB3015693 for ; Thu, 7 Sep 2023 17:31:40 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 387HVeE6015692 for bugs@FreeBSD.org; Thu, 7 Sep 2023 17:31:40 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 229719] src/lib/libpam/modules/pam_krb5/pam_krb5.c:536]: (style) Suspicious condition Date: Thu, 07 Sep 2023 17:31:40 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: misc X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D229719 --- Comment #2 from commit-hook@FreeBSD.org --- A commit in branch stable/13 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D27968aa02206baf85314305116fd63d55= a3bebf4 commit 27968aa02206baf85314305116fd63d55a3bebf4 Author: Dag-Erling Sm=C3=B8rgrav AuthorDate: 2023-08-04 16:08:21 +0000 Commit: Dag-Erling Sm=C3=B8rgrav CommitDate: 2023-09-07 17:27:55 +0000 pam_krb5: Clarify a loop condition. The closing parenthesis was in the wrong location, so instead of assign= ing the return value to krbret and then comparing it to zero, we were assigning= the result of the comparison to krbret and then comparing that to zero. This h= as no practical significance since the value is not used after the loop terminates. PR: 229719 Reviewed by: cy Differential Revision: https://reviews.freebsd.org/D41299 (cherry picked from commit acc7cf8641dcedad295ff0e569c3f3a28939ada0) pam_krb5: Rename a variable. Reviewed by: cy Differential Revision: https://reviews.freebsd.org/D41300 (cherry picked from commit 9c2823bae92c09e5356623118da2777bc3ed521d) lib/libpam/modules/pam_krb5/pam_krb5.c | 181 ++++++++++++++++-------------= ---- 1 file changed, 90 insertions(+), 91 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=