From owner-svn-src-head@freebsd.org  Mon Jun 11 18:40:55 2018
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 944AD100561B;
 Mon, 11 Jun 2018 18:40:55 +0000 (UTC)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 1247D758FB;
 Mon, 11 Jun 2018 18:40:54 +0000 (UTC)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1])
 by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id w5BIepGw029406;
 Mon, 11 Jun 2018 11:40:51 -0700 (PDT)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: (from freebsd@localhost)
 by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id w5BIepul029405;
 Mon, 11 Jun 2018 11:40:51 -0700 (PDT) (envelope-from freebsd)
From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net>
Message-Id: <201806111840.w5BIepul029405@pdx.rh.CN85.dnsmgr.net>
Subject: Re: svn commit: r334962 - head/sys/kern
In-Reply-To: <201806111710.w5BHAKr1069743@repo.freebsd.org>
To: Matt Macy <mmacy@freebsd.org>
Date: Mon, 11 Jun 2018 11:40:51 -0700 (PDT)
CC: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Reply-To: rgrimes@freebsd.org
X-Mailer: ELM [version 2.4ME+ PL121h (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Jun 2018 18:40:55 -0000

[ Charset UTF-8 unsupported, converting... ]
> Author: mmacy
> Date: Mon Jun 11 17:10:19 2018
> New Revision: 334962
> URL: https://svnweb.freebsd.org/changeset/base/334962
> 
> Log:
>   limit change to fixing controlp handling pending review

It is best to write commit messages that stand alone,
as at a later time when reading the log for this file
the null relative reference here may take some one
a time to figure out.

limit change of rXXXXXX to fixing controlp handling...
or something more direct would be better in the future
as one does not usually have the mail thread handy
at the time of log reading.

Thanks,
Rod

> Modified:
>   head/sys/kern/uipc_socket.c
> 
> Modified: head/sys/kern/uipc_socket.c
> ==============================================================================
> --- head/sys/kern/uipc_socket.c	Mon Jun 11 16:33:36 2018	(r334961)
> +++ head/sys/kern/uipc_socket.c	Mon Jun 11 17:10:19 2018	(r334962)
> @@ -2180,8 +2180,6 @@ soreceive_stream(struct socket *so, struct sockaddr **
>  		flags = *flagsp &~ MSG_EOR;
>  	else
>  		flags = 0;
> -	if (flags & (MSG_PEEK|MSG_WAITALL))
> -		return (soreceive_generic(so, psa, uio, mp0, controlp, flagsp));
>  	if (controlp != NULL)
>  		*controlp = NULL;
>  	if (flags & MSG_OOB)
> 
> 

-- 
Rod Grimes                                                 rgrimes@freebsd.org