From owner-cvs-all Mon Dec 17 17:22:13 2001 Delivered-To: cvs-all@freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 61E0937B417; Mon, 17 Dec 2001 17:22:09 -0800 (PST) Received: (from iedowse@localhost) by freefall.freebsd.org (8.11.6/8.11.6) id fBI1M9870892; Mon, 17 Dec 2001 17:22:09 -0800 (PST) (envelope-from iedowse) Message-Id: <200112180122.fBI1M9870892@freefall.freebsd.org> From: Ian Dowse Date: Mon, 17 Dec 2001 17:22:09 -0800 (PST) To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/nfs nfs_common.c nfs_common.h src/sys/nfsclient nfs_subs.c nfs_vfsops.c nfs_vnops.c nfsm_subs.h src/sys/nfsserver nfs_serv.c nfs_srvsubs.c nfsm_subs.h X-FreeBSD-CVS-Branch: HEAD Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG iedowse 2001/12/17 17:22:09 PST Modified files: sys/nfs nfs_common.c nfs_common.h sys/nfsclient nfs_subs.c nfs_vfsops.c nfs_vnops.c nfsm_subs.h sys/nfsserver nfs_serv.c nfs_srvsubs.c nfsm_subs.h Log: Avoid passing the variable `tl' to functions that just use it for temporary storage. In the old NFS code it wasn't at all clear if the value of `tl' was used across or after macro calls, but I'm fairly confident that the convention was to keep its use local. Each ex-macro function now uses a local version of this variable, so all of the double-indirection goes away. The only exception to the `local use' rule for `tl' is nfsm_clget(), which is left unchanged by this commit. Reviewed by: peter Revision Changes Path 1.109 +7 -6 src/sys/nfs/nfs_common.c 1.34 +5 -6 src/sys/nfs/nfs_common.h 1.111 +82 -79 src/sys/nfsclient/nfs_subs.c 1.108 +1 -2 src/sys/nfsclient/nfs_vfsops.c 1.181 +0 -10 src/sys/nfsclient/nfs_vnops.c 1.32 +23 -23 src/sys/nfsclient/nfsm_subs.h 1.110 +0 -10 src/sys/nfsserver/nfs_serv.c 1.110 +72 -72 src/sys/nfsserver/nfs_srvsubs.c 1.32 +13 -17 src/sys/nfsserver/nfsm_subs.h To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message