From owner-svn-src-all@FreeBSD.ORG Tue Oct 9 22:07:36 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 125B49D8 for ; Tue, 9 Oct 2012 22:07:36 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-pb0-f54.google.com (mail-pb0-f54.google.com [209.85.160.54]) by mx1.freebsd.org (Postfix) with ESMTP id C560B8FC1C for ; Tue, 9 Oct 2012 22:07:32 +0000 (UTC) Received: by mail-pb0-f54.google.com with SMTP id rp8so6375860pbb.13 for ; Tue, 09 Oct 2012 15:07:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=1Jq1MyTbcte64Ycjozh71ayKXcInc/HsvnuuO4KiEMY=; b=fQD1VNB6YkAki7UCvwB96ZmT7VTFtk+jIscItg8CjfumnkP9wxdZlkBRt9seH9kHVO Isd0779YffdFT3NA8elIin6TONMcOcBd9JUzzUREzN/trr14cUZpeMeSdbQZU2mzcvj8 9urjbQriQWnkh858XIXozIXWTqyHHSQcYinXk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :x-gm-message-state; bh=1Jq1MyTbcte64Ycjozh71ayKXcInc/HsvnuuO4KiEMY=; b=e9JZg2ex8xHNKahTbckWRiYfuSUQpYwLncyl2DKcbyI4Ma3mLOArlkzPGJsJL5Fcdz Fugs/70trfzL3o0/R8BQzlfS/OeZvZubFzyeXSPHBHxNVf3HF4SN9qeWdZlppco+haDK 4Rfvb3lXa6RQaqMe1t+4ox5Mn0x9Szbzj3c5FI4mJ5ObBWCkLLtgbVULNwhtIBbjIxft g+aDUuJZJM1CE6RCaezlfBXv69RXOUAcviHe7Z3N30VD07EDcPIUVTLIRCo6gQe9I5Oq 8lDrMyT1Fp3Ai9oNsMResVqDWRiPJ35AIq8JAvhnT9u0kiOzAcVqbjMTDPg6cr5eWJXq VvOg== Received: by 10.68.222.105 with SMTP id ql9mr67147769pbc.97.1349820446646; Tue, 09 Oct 2012 15:07:26 -0700 (PDT) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 10.66.161.163 with HTTP; Tue, 9 Oct 2012 15:06:55 -0700 (PDT) In-Reply-To: <20121009212538.GA67848@troutmask.apl.washington.edu> References: <201210091425.q99EPFS6020787@svn.freebsd.org> <507451DE.9060909@freebsd.org> <50746BF8.5010307@freebsd.org> <20121009212538.GA67848@troutmask.apl.washington.edu> From: Eitan Adler Date: Tue, 9 Oct 2012 18:06:55 -0400 X-Google-Sender-Auth: bb3HpjCOHUfrfqdZEbyFZzB8ao0 Message-ID: Subject: Re: svn commit: r241373 - head/lib/libc/stdlib To: Steve Kargl Content-Type: text/plain; charset=UTF-8 X-Gm-Message-State: ALoCoQmsCcwufS/xaB0PokprY0c2MZOMP700vYeR7ETJh3qP5g3cmsoiGz5Mo6/ooHyAKGxp2rEN Cc: svn-src-head@freebsd.org, theraven@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Andrey Chernov X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Oct 2012 22:07:36 -0000 On 9 October 2012 17:25, Steve Kargl wrote: ... yes, I was misreading the text. > Clang has no way of determining if 'a' is initialized or not. > If David is correct that 'junk' is optimized out by clang/llvm, > then it seems that clang violates footnote 116. Yes, I know > it is non-normative text. Sorry if I was not clear: clang does *not* optimize away the volatile version. I removed it for other reasons. > >> I still don't like volatile though here for the other reasons >> mentioned. In general, the entire piece of code should be replaced >> with something that can't fail, so this is a moot point. > > Agreed. > > -- > Steve > -- Eitan Adler Source & Ports committer X11, Bugbusting teams