From owner-freebsd-bugs  Wed Aug 15  7:20: 8 2001
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 04FDF37B40E
	for <freebsd-bugs@hub.freebsd.org>; Wed, 15 Aug 2001 07:20:01 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.11.4/8.11.4) id f7FEK0526318;
	Wed, 15 Aug 2001 07:20:00 -0700 (PDT)
	(envelope-from gnats)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id A18AA37B406
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 15 Aug 2001 07:10:17 -0700 (PDT)
	(envelope-from nobody@FreeBSD.org)
Received: (from nobody@localhost)
	by freefall.freebsd.org (8.11.4/8.11.4) id f7FEAHO25210;
	Wed, 15 Aug 2001 07:10:17 -0700 (PDT)
	(envelope-from nobody)
Message-Id: <200108151410.f7FEAHO25210@freefall.freebsd.org>
Date: Wed, 15 Aug 2001 07:10:17 -0700 (PDT)
From: Joseph Mallett <jmallett@xMach.org>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-1.0
Subject: misc/29730: su usage info shows incorrect info
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-bugs.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-bugs>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-bugs>
X-Loop: FreeBSD.org


>Number:         29730
>Category:       misc
>Synopsis:       su usage info shows incorrect info
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Aug 15 07:20:00 PDT 2001
>Closed-Date:
>Last-Modified:
>Originator:     Joseph Mallett
>Release:        4.3-STABLE
>Organization:
xMach
>Environment:
>Description:
Someone decided it would be easy to just insert the string used by getopt() in the usage fprintf, but this is bad, because as the c flag requires an argument, it has a colon after it, and the usage output might lead a reader to believe 'su -:' did something.
>How-To-Repeat:
Type su -c without any argument.
>Fix:
--- su.orig     Tue Jun 19 00:26:30 2001
+++ su.c        Wed Aug 15 14:04:29 2001
@@ -413,7 +413,7 @@
 static void
 usage()
 {
-       (void)fprintf(stderr, "usage: su [%s] [login [args]]\n", ARGSTR);
+       (void)fprintf(stderr, "usage: su [-flm] [-c class] [login [args]]\n");
        exit(1);
 }
>Release-Note:
>Audit-Trail:
>Unformatted:

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message