From owner-svn-src-head@freebsd.org Tue Sep 27 21:00:35 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id ED5D6C00AEC; Tue, 27 Sep 2016 21:00:35 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from mail.baldwin.cx (bigwig.baldwin.cx [96.47.65.170]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id CA781304; Tue, 27 Sep 2016 21:00:35 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by mail.baldwin.cx (Postfix) with ESMTPSA id D036010AF8D; Tue, 27 Sep 2016 17:00:28 -0400 (EDT) From: John Baldwin To: Oleksandr Tymoshenko Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r306355 - in head/sys: dev/atkbdc sys Date: Tue, 27 Sep 2016 13:55:54 -0700 Message-ID: <3815150.rnkVxtqPiv@ralph.baldwin.cx> User-Agent: KMail/4.14.10 (FreeBSD/11.0-PRERELEASE; KDE/4.14.10; amd64; ; ) In-Reply-To: <201609262206.u8QM6J5q070986@repo.freebsd.org> References: <201609262206.u8QM6J5q070986@repo.freebsd.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mail.baldwin.cx); Tue, 27 Sep 2016 17:00:28 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx X-Virus-Status: Clean X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Sep 2016 21:00:36 -0000 On Monday, September 26, 2016 10:06:19 PM Oleksandr Tymoshenko wrote: > Author: gonzo > Date: Mon Sep 26 22:06:19 2016 > New Revision: 306355 > URL: https://svnweb.freebsd.org/changeset/base/306355 > > Log: > Add Elantech trackpad support > > Elantech trackpads are found in some laptops like the Asus UX31E. They > are "synaptics compatible" but use a slightly different protocol. > > Elantech hardware support is not enabled by default and just like > Synaptic or TrackPoint devices it should be enabled by setting > tunable, in this case hw.psm.elantech_support, to non-zero value > > PR: 205690 > Submitted by: Vladimir Kondratyev > MFC after: 1 week > > Modified: head/sys/dev/atkbdc/psm.c > ============================================================================== > --- head/sys/dev/atkbdc/psm.c Mon Sep 26 20:26:19 2016 (r306354) > +++ head/sys/dev/atkbdc/psm.c Mon Sep 26 22:06:19 2016 (r306355) > @@ -389,6 +465,9 @@ TUNABLE_INT("hw.psm.synaptics_support", > static int trackpoint_support = 0; > TUNABLE_INT("hw.psm.trackpoint_support", &trackpoint_support); > > +static int elantech_support = 0; > +TUNABLE_INT("hw.psm.elantech_support", &elantech_support); > + > static int verbose = PSM_DEBUG; > TUNABLE_INT("debug.psm.loglevel", &verbose); It would be good to expose all these tunables as CTLFLAG_RDTUN sysctls. Exposing them that way with a decent description string makes it easier for users to discover tunables. -- John Baldwin