From owner-freebsd-mobile Mon Apr 30 13: 5:21 2001 Delivered-To: freebsd-mobile@freebsd.org Received: from blues.viagenie.qc.ca (blues.viagenie.qc.ca [206.123.31.135]) by hub.freebsd.org (Postfix) with ESMTP id 30E6837B63A for ; Mon, 30 Apr 2001 13:05:14 -0700 (PDT) (envelope-from Florent.Parent@viagenie.qc.ca) Received: from localhost (localhost [127.0.0.1]) by blues.viagenie.qc.ca (8.11.3/8.11.3) with ESMTP id f3UKASf03083; Mon, 30 Apr 2001 16:10:28 -0400 (EDT) (envelope-from Florent.Parent@viagenie.qc.ca) Date: Mon, 30 Apr 2001 16:10:28 -0400 (EDT) From: Florent Parent X-X-Sender: To: gollum Cc: Subject: Re: Fix for csa driver under 4.x In-Reply-To: <20010425121757.A480@jellyfish.codefactory.se> Message-ID: X-PGP-Fingerprint: B7 18 45 43 97 7C BE 73 2B CC 23 D5 3E 20 4F C9 2A 90 87 2C MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Sender: owner-freebsd-mobile@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org Works on A20p with FreeBSD-4.3 stable. Had to set PCI IRQs to their default settings (all on IRQ 11). Thanks! Florent. On Wed, 25 Apr 2001, Anders Andersson wrote: > On Tis, Apr 24, 2001 at 10:10:44pm -0700, gollum wrote: > > The follow fix solved the sound issue on my T21 (CS461x) laptop running > > 4.3 FreeBSD. The issue was two function parameters that were backwards > > in the pci_write_config call in the csa_attach function. This fix sould > > solve the sound issue for the csa driver under 4.2 also, however, I have > > yet to test it. NOTE: This fix has been added to the HEAD CVS tree, but > > has yet to be added to RELENG_4. > > > > The following diff shows the fix for the csa.c file under > > /usr/src/sys/dev/sound/pci: > > > > *** csa.c Tue Apr 24 21:51:45 2001 > > --- csa.c.broken Tue Apr 24 20:47:38 2001 > > *************** > > *** 131,137 **** > > stcmd = pci_read_config(dev, PCIR_COMMAND, 4); > > if ((stcmd & PCIM_CMD_MEMEN) == 0 || (stcmd & PCIM_CMD_BUSMASTEREN) == 0) { > > stcmd |= (PCIM_CMD_MEMEN | PCIM_CMD_BUSMASTEREN); > > ! pci_write_config(dev, PCIR_COMMAND, stcmd, 4); > > } > > > > /* Allocate the resources. */ > > --- 131,137 ---- > > stcmd = pci_read_config(dev, PCIR_COMMAND, 4); > > if ((stcmd & PCIM_CMD_MEMEN) == 0 || (stcmd & PCIM_CMD_BUSMASTEREN) == 0) { > > stcmd |= (PCIM_CMD_MEMEN | PCIM_CMD_BUSMASTEREN); > > ! pci_write_config(dev, PCIR_COMMAND, 4, stcmd); > > } > > > > /* Allocate the resources. */ > > > > > > > > > > This patch makes sound work on my IBM ThinkPad A20p > > csa0: Audio controller> mem 0xf0000000-0xf00fffff,0xf0121000-0xf0121fff irq 11 > at device 5.0 on pci0 > pcm0: on csa0 > > -- Florent Parent Viagénie inc. http://www.viagenie.qc.ca +1.418.656.9254 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-mobile" in the body of the message