From owner-svn-src-all@freebsd.org Sun Feb 5 01:26:14 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2BB93CD03D9; Sun, 5 Feb 2017 01:26:14 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from smtp-out-no.shaw.ca (smtp-out-no.shaw.ca [64.59.134.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id D41421CA; Sun, 5 Feb 2017 01:26:13 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from spqr.komquats.com ([96.50.22.10]) by shaw.ca with SMTP id aBalcNdzIcWiHaBamcfiu4; Sat, 04 Feb 2017 18:26:12 -0700 X-Authority-Analysis: v=2.2 cv=JLBLi4Cb c=1 sm=1 tr=0 a=jvE2nwUzI0ECrNeyr98KWA==:117 a=jvE2nwUzI0ECrNeyr98KWA==:17 a=kj9zAlcOel0A:10 a=n2v9WMKugxEA:10 a=YxBL1-UpAAAA:8 a=6I5d2MoRAAAA:8 a=BWvPGDcYAAAA:8 a=pSDo845uDOqUOBJDyvoA:9 a=CjuIK1q_8ugA:10 a=Ia-lj3WSrqcvXOmTRaiG:22 a=IjZwj45LgO3ly-622nXo:22 a=pxhY87DP9d2VeQe4joPk:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id E5EDAE47; Sat, 4 Feb 2017 17:26:10 -0800 (PST) Received: from slippy (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id v151QAfE005740; Sat, 4 Feb 2017 17:26:10 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201702050126.v151QAfE005740@slippy.cwsent.com> X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.6 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Warner Losh cc: Cy Schubert , Warner Losh , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Subject: Re: svn commit: r313191 - head/sbin/nvmecontrol In-Reply-To: Message from Warner Losh of "Sat, 04 Feb 2017 18:21:02 -0700." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sat, 04 Feb 2017 17:26:10 -0800 X-CMAE-Envelope: MS4wfCFKt1/Hb7D8lxi/MB2abphm3zNUPnmB2CuHquwSMdxDAo/41yQW6S9rFLZG9//8om+R3YDh3MklJYxD/9UKR7hKFYYQZNFJEDQE3pjswDP2Dj6SuKxr 1yjdUvaoCn02yb0dq9f4ngA39NpWf2FbvslbCjfWKCSoB1Xe6L+kf7LYWIoQCsxEv8kuGDwOZ7LAgM3U8uj/M3BI8mlvlFfL+Ne2rjfDiHzY9ZsKD03lQwg+ 40UgCZS3qBlw96DTEm5+ZSngNDODb63ka0QoSJP3hjDkWaC1x36qzwt3wrhBue/axgA8643J/MQuL0rIn93xmw== X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Feb 2017 01:26:14 -0000 Thanks. -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few. In message , Warner Losh writes: > Thanks! Fixed in r313259. > > Warner > > On Sat, Feb 4, 2017 at 6:16 PM, Cy Schubert wrote: > > In message <201702040553.v145r1wB002775@repo.freebsd.org>, Warner Losh > > writes: > >> Author: imp > >> Date: Sat Feb 4 05:53:00 2017 > >> New Revision: 313191 > >> URL: https://svnweb.freebsd.org/changeset/base/313191 > >> > >> Log: > >> Implement 5 wdc-specific nvme control options for their HGST drives: > >> wdc cap-diag Capture diagnostic data from drive > >> wdc drive-log Capture drive history data from drive > >> wdc get-crash-dump Retrieve firmware crash dump from drive > >> > >> Added: > >> head/sbin/nvmecontrol/wdc.c (contents, props changed) > >> Modified: > >> head/sbin/nvmecontrol/Makefile > >> head/sbin/nvmecontrol/nvmecontrol.8 > >> head/sbin/nvmecontrol/nvmecontrol.c > >> head/sbin/nvmecontrol/nvmecontrol.h > > [...] > >> + while (len > 0) { > >> + resid = len > NVME_MAX_XFER_SIZE ? NVME_MAX_XFER_SIZE : len; > >> + wdc_get_data(fd, opcode, resid, offset, cmd, buf, resid); > >> + if (write(fd2, buf, resid) != resid) > > > > Hi Warner, > > > > I'm seeing the following on i386. > > > > opt/src/svn-current/sbin/nvmecontrol/wdc.c:156:30: error: comparison of > > integers of different signs: 'ssize_t' (aka 'int') and 'uint32_t' (aka > > 'unsigned int') [-Werror,-Wsign-compare] > > if (write(fd2, buf, resid) != resid) > > ~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~ > > 1 error generated. > > > > amd64 builds okay. > > > >> + err(1, "write"); > >> + offset += resid; > >> + len -= resid; > >> + } > >> + free(buf); > >> + close(fd2); > > [...] > > > > > > -- > > Cheers, > > Cy Schubert > > FreeBSD UNIX: Web: http://www.FreeBSD.org > > > > The need of the many outweighs the greed of the few. > > > > > >