From owner-freebsd-current Fri Nov 2 1: 1:48 2001 Delivered-To: freebsd-current@freebsd.org Received: from mail6.speakeasy.net (mail6.speakeasy.net [216.254.0.206]) by hub.freebsd.org (Postfix) with ESMTP id 06DA737B403 for ; Fri, 2 Nov 2001 01:01:31 -0800 (PST) Received: (qmail 78581 invoked from network); 2 Nov 2001 09:01:30 -0000 Received: from unknown (HELO laptop.baldwin.cx) ([64.81.54.73]) (envelope-sender ) by mail6.speakeasy.net (qmail-ldap-1.03) with SMTP for ; 2 Nov 2001 09:01:30 -0000 Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20011031225509.A17837@coffee.q9media.com> Date: Fri, 02 Nov 2001 01:01:29 -0800 (PST) From: John Baldwin To: Mike Barcroft Subject: Re: Revert awk to one that works Cc: freebsd-current@FreeBSD.ORG, Steve Kargl , "David O'Brien" , Doug Barton Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 01-Nov-01 Mike Barcroft wrote: > Doug Barton writes: >> On Wed, 31 Oct 2001, David O'Brien wrote: >> > I *DID* test it with a full `make world'. By chance is this your second >> > `make world' after the change? It seems we are using the host awk >> > instead of the one we built. Requiring someone to do two back-to-back >> > `make world's before a commit has never been a requirement. Some things >> > we just find out after a commit. >> >> "Required" isn't really the question. It seems like common sense >> to me when discussing such a frequently used build tool. > > I'm sure there's better things you could be doing besides lecturing > David about testing his changes before committing. Not every bug can > be found before committing, which is why we have a little thing called > -CURRENT. And the irony being that David has one of the best test methodologies of any committer I know. The number of torture tests he has submitted binutils and gcc updates to in the past is amazing. So he missed one, give him a break and help fix it if you can. -- John Baldwin -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message