From owner-freebsd-bugs Mon Jan 27 23:11:13 2003 Delivered-To: freebsd-bugs@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8152037B401; Mon, 27 Jan 2003 23:11:12 -0800 (PST) Received: from out6.mx.nwbl.wi.voyager.net (out6.mx.nwbl.wi.voyager.net [169.207.3.77]) by mx1.FreeBSD.org (Postfix) with ESMTP id 07D4743F85; Mon, 27 Jan 2003 23:11:12 -0800 (PST) (envelope-from silby@silby.com) Received: from [10.1.1.6] (d171.as21.nwbl0.wi.voyager.net [169.207.139.237]) by out6.mx.nwbl.wi.voyager.net (Postfix) with ESMTP id 3FFC8DBBBE; Tue, 28 Jan 2003 01:11:10 -0600 (CST) Date: Tue, 28 Jan 2003 01:19:01 -0600 (CST) From: Mike Silbersack To: Gregory Bond Cc: "Crist J. Clark" , "" Subject: Re: kern/43348: PATCH: make tcp.log_in_vain distinguish SYN from SYN-ACK In-Reply-To: <200301280620.RAA00710@lightning.itga.com.au> Message-ID: <20030128011805.D1283-100000@patrocles.silby.com> References: <200301280620.RAA00710@lightning.itga.com.au> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org On Tue, 28 Jan 2003, Gregory Bond wrote: > > Wouldn't it be easier just to add the TCP flags of the offending > > packet to the log entry like we do for 2? > > Maybe, if you can remember all the TCP flags bitmasks in your head! > > (I'd be happy with this as a solution BTW). I can't remember the various flags either, I think that the original patch is better in that sense. That being said, I won't get to this for a few more days _at least_. Crist, if you want to handle this PR, be my guest; I just assigned it to myself so that it did not get lost. Mike "Silby" Silbersack To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message