From owner-freebsd-current@FreeBSD.ORG Sat Jul 16 15:53:50 2011 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B9EC1106566C; Sat, 16 Jul 2011 15:53:50 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-iw0-f182.google.com (mail-iw0-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id 7351C8FC12; Sat, 16 Jul 2011 15:53:50 +0000 (UTC) Received: by iwr19 with SMTP id 19so2380288iwr.13 for ; Sat, 16 Jul 2011 08:53:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=zyxtn8QcB0Yqa0YnPKVRTysNXz3JGEsnuukJZieo9yo=; b=ErBht7SeQWL2cgi3/pFn4PrkP+99ojf/mA3OODAyWsulif/8h2asS57buAzTV3g40m Tlld8E8nh5Xc3DTDt95IGawtqjvueTi87VBMqWyvM42eNG5od5B6WsF1K16yAwB4QthE kaKCNGpuUK1Juxu+x/mZAPoqb2b1plMSJHsFo= MIME-Version: 1.0 Received: by 10.231.118.18 with SMTP id t18mr4213486ibq.60.1310831629204; Sat, 16 Jul 2011 08:53:49 -0700 (PDT) Received: by 10.231.67.211 with HTTP; Sat, 16 Jul 2011 08:53:49 -0700 (PDT) Received: by 10.231.67.211 with HTTP; Sat, 16 Jul 2011 08:53:49 -0700 (PDT) In-Reply-To: <4E21B051.5040502@missouri.edu> References: <4E20FADE.6060103@missouri.edu> <4E21B051.5040502@missouri.edu> Date: Sat, 16 Jul 2011 16:53:49 +0100 Message-ID: From: Chris Rees To: Stephen Montgomery-Smith X-Mailman-Approved-At: Sat, 16 Jul 2011 16:00:19 +0000 Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: "freebsd@sopwith.solgatos.com" , "current@freebsd.org" , "bug-followup@freebsd.org" , Stefan Bethke Subject: Re: ports/158179: some packages do not fully honor -P dir option in pkg_add(1) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Jul 2011 15:53:50 -0000 On 16 Jul 2011 16:38, "Stephen Montgomery-Smith" wrote: > > On 07/16/2011 04:26 AM, Stefan Bethke wrote: >> >> Am 16.07.2011 um 04:43 schrieb Stephen Montgomery-Smith: >> >>> I was looking through the source code of pkg_add. Personally I don't see how the "-P" or "-p" option could be made to work with pkg_add. Many of the installation commands involve scripts which have ${PREFIX} hard coded into them. ${PREFIX} is often hard coded when trhe package is created by the port. In my opinion, the options "-p" and "-P" should be removed from pkg_add. >>> >>> Either that, or provide the port a way to access "@cwd" in any scripts it installs. But this would require a major overhaul of the whole ports system, and probably much of the software it installs as well. >>> >>> Am I missing something? >> >> >> Yes. Not honoring the prefix is a bug in the port. If you do need to do prefix-specific things during install, use pkg-install, see http://www.freebsd.org/doc/en/books/porters-handbook/pkg-install.html >> >> I suspect that many ports are not well tested outside of "/usr/local", but the infrastructure is there and available. > > > You are correct, this needs to be done on a port by port basis. In some ports this is going to be a big job, because in some cases the "/usr/local" is hard coded into certain binaries. > > For example, suppose the C source code contains something like: > char applications_dir = "/usr/local/share/applications"; > and this is filled in by the ./configure script. > > How is that handled? > It's not. Remember what a package is, literally the files from the plist tarred with some magic +FILEs and the pkg-*install files- if paths are hardcoded in objects that's how it'll be installed. Don't touch the -p option! It's only useful for.... um.... someone help here? Chris