From owner-p4-projects@FreeBSD.ORG Mon Apr 23 19:54:06 2007 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 122AD16A402; Mon, 23 Apr 2007 19:54:06 +0000 (UTC) X-Original-To: perforce@freebsd.org Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7235A16A400 for ; Mon, 23 Apr 2007 19:54:05 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.freebsd.org (Postfix) with ESMTP id 13BFD13C465 for ; Mon, 23 Apr 2007 19:54:02 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l3NJrnV4049908; Mon, 23 Apr 2007 15:53:59 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Matt Jacob Date: Mon, 23 Apr 2007 15:09:13 -0400 User-Agent: KMail/1.9.6 References: <200704202333.l3KNXp1S061688@repoman.freebsd.org> In-Reply-To: <200704202333.l3KNXp1S061688@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200704231509.13720.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Mon, 23 Apr 2007 15:53:59 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/3151/Mon Apr 23 12:11:26 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: Perforce Change Reviews Subject: Re: PERFORCE change 118502 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Apr 2007 19:54:06 -0000 On Friday 20 April 2007 07:33:51 pm Matt Jacob wrote: > http://perforce.freebsd.org/chv.cgi?CH=118502 > > Change 118502 by mjacob@mjexp on 2007/04/20 23:32:53 > > While it's true we have motherboard blacklists for MSI > breakage, it's true that this is incomplete. Save ourselves > some grief by not trying to do MSI for Ultra320 chips. > > MFP4 after: 1 days Is it due to a broken motherboard or broken mpt(4) silicon? If the former, do you have a system where it breaks? > Affected files ... > > .. //depot/projects/mjexp/sys/dev/mpt/mpt_pci.c#9 edit > > Differences ... > > ==== //depot/projects/mjexp/sys/dev/mpt/mpt_pci.c#9 (text+ko) ==== > > @@ -522,11 +522,13 @@ > > /* Get a handle to the interrupt */ > iqd = 0; > + > /* > * First try to alloc an MSI-X message. If that > * fails, then try to alloc an MSI message instead. > + * Don't do this for U320 chips. > */ > - if (pci_msix_count(dev) == 1) { > + if (mpt->is_spi == 0 && pci_msix_count(dev) == 1) { > mpt->pci_msi_count = 1; > if (pci_alloc_msix(dev, &mpt->pci_msi_count) == 0) { > iqd = 1; > @@ -534,7 +536,7 @@ > mpt->pci_msi_count = 0; > } > } > - if (iqd == 0 && pci_msi_count(dev) == 1) { > + if (mpt->is_spi == 0 && iqd == 0 && pci_msi_count(dev) == 1) { > mpt->pci_msi_count = 1; > if (pci_alloc_msi(dev, &mpt->pci_msi_count) == 0) { > iqd = 1; > -- John Baldwin