From owner-freebsd-current@freebsd.org Mon Oct 10 16:31:24 2016 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A2DD2C0B4B7 for ; Mon, 10 Oct 2016 16:31:24 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citapm.icyb.net.ua (citapm.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id B90DDD1E; Mon, 10 Oct 2016 16:31:23 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citapm.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id TAA20429; Mon, 10 Oct 2016 19:31:21 +0300 (EEST) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1btdU1-000FS4-47; Mon, 10 Oct 2016 19:31:21 +0300 Subject: Re: [request for testing] isl, cyapa on chromebooks To: Warner Losh , Michael Gmelin References: <53bca4d2-975f-f4a0-d12a-5d73fba01a0c@FreeBSD.org> <20161006044732.GA2393@c720-r292778-amd64.oa.oclc.org> <734c7ac0-9018-051e-1df4-a3b719057e19@FreeBSD.org> <773efe54-8ebb-e0e7-7824-10cfaa96d850@FreeBSD.org> <1EE0A2F3-86B9-4806-875E-3845A209A743@freebsd.org> <20161008180742.GA1912@c720-r292778-amd64> <846bf31f-a757-2be0-a293-8c4ce3d42a2f@FreeBSD.org> <20161009015324.007a7b42@bsd64.grem.de> <20161009065423.GA2012@c720-r292778-amd64> <23c6b4f0-77e9-fe90-0eed-9d0125e7624b@FreeBSD.org> <20161010134610.32120b55@bsd64.grem.de> Cc: Matthias Apitz , FreeBSD Current From: Andriy Gapon Message-ID: <50c65364-49f3-30b2-8c42-763daec96b55@FreeBSD.org> Date: Mon, 10 Oct 2016 19:30:24 +0300 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Oct 2016 16:31:24 -0000 On 10/10/2016 18:26, Warner Losh wrote: > I see no reason not to start the table right away based on > smbios.sys.product and other criteria. I don't think we need all the > matches that Linux uses, but we can expand the table if we find it so. > Why have a stop gap that's a table that we kludge together when the > real table is of comparable difficulty and wouldn't need to be > reworked. One simple reason for me personally. I do not have the hardware and I am not particularly interested in it. I am interested only in cleaning up the smbus interface and moving ig4iic to iicbus. I want to get done with that as quickly as possible and my goal is just that the result is not worse than the current code. I am sure that people who are more interested than me can make the code much better. > On Mon, Oct 10, 2016 at 5:46 AM, Michael Gmelin wrote: >> On Mon, 10 Oct 2016 14:35:22 +0300 >> Andriy Gapon wrote: >> >>> On 09/10/2016 23:22, Warner Losh wrote: >>>> There seems to be enough information present in the smbios data to >>>> know what devices are at what addresses. Perhaps we should use it as >>>> much as possible in well controlled situations to move this >>>> knowledge into the OS. >>> >>> So, I was thinking about maybe doing something like this to preserve >>> the status quo, to avoid requiring manual hints and to lay a >>> foundation for the proper Chromebook I2C slave discovery: >>> [snip] -- Andriy Gapon