From owner-freebsd-usb@freebsd.org Fri Jan 10 02:29:31 2020 Return-Path: Delivered-To: freebsd-usb@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 35EE61FFFE7 for ; Fri, 10 Jan 2020 02:29:31 +0000 (UTC) (envelope-from Shichun.Ma@dell.com) Received: from mx0b-00154904.pphosted.com (mx0b-00154904.pphosted.com [148.163.137.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 47v6Pj6M5xz42xJ for ; Fri, 10 Jan 2020 02:29:29 +0000 (UTC) (envelope-from Shichun.Ma@dell.com) Received: from pps.filterd (m0170394.ppops.net [127.0.0.1]) by mx0b-00154904.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 00A2TSOD028005 for ; Thu, 9 Jan 2020 21:29:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dell.com; h=from : to : cc : subject : date : message-id : content-type : mime-version; s=smtpout1; bh=8Q8OHYptoxKGHFcTP0e2UpThcU2iqtkgNjqobbw/GJ0=; b=V9dz75hx2/JRQPj2pdko+rMIQtpmySDX0UvChtk/CQiorfke8laAq8HH8jsfUZcmgcjD Lma4geDTUM8TpERFdSbr1rQSp47ToJGrytaEZFXuzVDgmB+J1kdmL9bVusFT25JD4sAk Qk6Bq9d5ffVOxTkh3tw0B9HVcvo+0MOADVjRcHG1Tckme7k52bVVIffmVT5QPDIwq5UG HTomMWEZovJkfY1i+xKzEZpVO8EBkeXWHVmYfYCnbLsHXwPj58KGdorhAc5Me6ZARPrZ 6Q81bclrAfLG0wTX1ELzxDh3ytKNbw/yJ8X7o1cXdkO9Yn6/Xr08iBqCPUhudrsqy7u7 3g== Received: from mx0b-00154901.pphosted.com (mx0b-00154901.pphosted.com [67.231.157.37]) by mx0b-00154904.pphosted.com with ESMTP id 2xe4knayq1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 09 Jan 2020 21:29:28 -0500 Received: from pps.filterd (m0144104.ppops.net [127.0.0.1]) by mx0b-00154901.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 00A2Ndje132474 for ; Thu, 9 Jan 2020 21:29:28 -0500 Received: from ausxipps301.us.dell.com (ausxipps301.us.dell.com [143.166.148.223]) by mx0b-00154901.pphosted.com with ESMTP id 2xdjsjs95t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 09 Jan 2020 21:29:27 -0500 X-LoopCount0: from 10.166.135.138 X-PREM-Routing: D-Outbound X-IronPort-AV: E=Sophos;i="5.60,349,1549951200"; d="scan'208,217";a="444025061" From: To: , CC: Subject: minor improve for xhci_cmd_stop_ep in xhci_configure_reset_endpoint Thread-Topic: minor improve for xhci_cmd_stop_ep in xhci_configure_reset_endpoint Thread-Index: AQHVx1zY/T1s1lBQl02qpmHnCbNkTw== Date: Fri, 10 Jan 2020 02:29:22 +0000 Message-ID: <1578623361805.72194@Dell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.143.18.86] MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.572 definitions=2020-01-09_06:2020-01-09, 2020-01-09 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 malwarescore=0 adultscore=0 mlxlogscore=765 bulkscore=0 mlxscore=0 lowpriorityscore=0 clxscore=1015 phishscore=0 priorityscore=1501 impostorscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1910280000 definitions=main-2001100021 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 lowpriorityscore=0 bulkscore=0 impostorscore=0 clxscore=1015 priorityscore=1501 spamscore=0 malwarescore=0 phishscore=0 adultscore=0 mlxlogscore=920 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1910280000 definitions=main-2001100022 X-Rspamd-Queue-Id: 47v6Pj6M5xz42xJ X-Spamd-Bar: ------- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=dell.com header.s=smtpout1 header.b=V9dz75hx; dmarc=pass (policy=none) header.from=dell.com; spf=pass (mx1.freebsd.org: domain of Shichun.Ma@dell.com designates 148.163.137.20 as permitted sender) smtp.mailfrom=Shichun.Ma@dell.com X-Spamd-Result: default: False [-7.56 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[dell.com:s=smtpout1]; HAS_XOIP(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; RCVD_COUNT_FIVE(0.00)[5]; R_SPF_ALLOW(-0.20)[+ip4:148.163.137.20]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-usb@freebsd.org]; TO_DN_NONE(0.00)[]; DWL_DNSWL_LOW(-1.00)[dell.com.dwl.dnswl.org : 127.0.9.1]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[dell.com:+]; DMARC_POLICY_ALLOW(-0.50)[dell.com,none]; FROM_NO_DN(0.00)[]; RCVD_TLS_LAST(0.00)[]; RCVD_IN_DNSWL_LOW(-0.10)[20.137.163.148.list.dnswl.org : 127.0.3.1]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:22843, ipnet:148.163.137.0/24, country:US]; MID_RHS_MATCH_FROM(0.00)[]; IP_SCORE(-0.46)[ip: (-0.17), ipnet: 148.163.137.0/24(-0.07), asn: 22843(-2.03), country: US(-0.05)]; WHITELIST_SPF_DKIM(-3.00)[dell.com:d:+,dell.com:s:+] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Jan 2020 02:29:31 -0000 Hi HPS, As subject, this is just an minor improvement. When do first xfer on one ep, it use xhci_configure_reset_endpoint to star= t ep, in current cases, no need send xhci_cmd_stop_ep command. And xhci_cmd_stop_ep will return XHCI_TRB_ERROR_CONTEXT_STATE if it's not a= t running status. Could you consider and below check before callxhci_cmd_stop_ep? pcctx =3D &sc->sc_hw.devs[index].device_pc; usbd_get_page(pcctx, 0, &buf_dev); pdev =3D buf_dev.buffer; ctx_ep =3D &pdev->ctx_ep[epno - 1]; ep_status =3D XHCI_EPCTX_0_EPSTATE_GET(ctx_ep->dwEpCtx0); if ((ep_status =3D=3D 0) || (ep_status =3D=3D EP_STOPPED)) { KLOGN(KDBG, "ep %x is not started yet\n", edesc->bEndpointA= ddress); } else { err =3D xhci_cmd_stop_ep(sc, 0, epno, index); if (err) KLOGN(KWARN, "stop endpoint %u, %x, %d\n", epno, edesc->bEndpointAddress, err); } Thanks & Regards, Shichun Ma Software Engineer Dell | Cloud Client Computing office +86 10 82862579, Mobile +86 13241851528 shichun_ma@dell.com