Date: Tue, 13 Nov 2018 22:01:14 +0100 From: Andreas Longwitz <longwitz@incore.de> To: Kristof Provost <kristof@sigsegv.be> Cc: freebsd-pf@freebsd.org Subject: Re: rdr pass for proto tcp sometimes creates states with expire time zero and so breaking connections Message-ID: <5BEB3B9A.9080402@incore.de> In-Reply-To: <D5EEA773-1F0F-4FA0-A39A-486EE323907D@sigsegv.be> References: <5BC51424.5000309@incore.de> <C4D1F141-2979-4103-957F-F0314637D978@sigsegv.be> <5BD45882.1000207@incore.de> <D5EEA773-1F0F-4FA0-A39A-486EE323907D@sigsegv.be>
next in thread | previous in thread | raw e-mail | index | archive | help
>
> Are there any hints why the counter pf_default_rule->states_cur
> could get a negative value ?
>
> I’m afraid I have no idea right now.
>
OK, in the meantime I did some more research and I am now quite sure the
problem with the bogus pf_default_rule->states_cur counter is not a
problem in pf. I am convinced it is a problem in counter(9) on i386
server. The critical code is the machine instruction cmpxchg8b used in
/sys/i386/include/counter.h.
>From intel instruction set reference manual:
Zhis instruction can be used with a LOCK prefix allow the instruction to
be executed atomically.
We have two other sources in kernel using cmpxchg8b:
/sys/i386/include/atomic.h and
/sys/cddl/contrib/opensolaris/common/atomic/i386/opensolaris_atomic.S
Both make use of the LOCK feature, in atomic.h a detailed explanation is
given. Because counter.h lacks the LOCK prefix I propose the following
patch to get around the leak:
--- counter.h.orig 2015-07-03 16:45:36.000000000 +0200
+++ counter.h 2018-11-13 16:07:20.329053000 +0100
@@ -60,6 +60,7 @@
"movl %%edx,%%ecx\n\t"
"addl (%%edi),%%ebx\n\t"
"adcl 4(%%edi),%%ecx\n\t"
+ "lock \n\t"
"cmpxchg8b %%fs:(%%esi)\n\t"
"jnz 1b"
:
@@ -76,6 +77,7 @@
__asm __volatile(
"movl %%eax,%%ebx\n\t"
"movl %%edx,%%ecx\n\t"
+ "lock \n\t"
"cmpxchg8b (%2)"
: "=a" (res_lo), "=d"(res_high)
: "SD" (p)
@@ -121,6 +123,7 @@
"xorl %%ebx,%%ebx\n\t"
"xorl %%ecx,%%ecx\n\t"
"1:\n\t"
+ "lock \n\t"
"cmpxchg8b (%0)\n\t"
"jnz 1b"
:
Kindly regards,
Andreas
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5BEB3B9A.9080402>