From nobody Mon Feb 2 13:31:23 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f4SF741zmz6QVXF for ; Mon, 02 Feb 2026 13:31:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f4SF731y9z415T for ; Mon, 02 Feb 2026 13:31:23 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770039083; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WefFLAo6FOmnJIzJZRkzOrAS7WseRIBj723LBqHvReo=; b=CXsQuT7NqAKNS4hZJIOQa/Kxjwq/vkCuORQgK3gfZVYJ9jEE7L9AQB69l+8S72C535M0Su 3vLn2iH0h1j3MGRIKQY20x1jgm849EEl7G7P/uat19xShgd3CifSBZn9oaWTwirIxXz60T 75Tm3XgtXcCuYs0aBukaZEXukmqc+h4ZhItB6Qam28WBpDYEf76sxWntLhYiHz//CKmgQ/ xQDyZPvbUlAUwXntvzovfjLNHdcuG4awUeFdHnI5CMjZtV2IjwSYWMxF8zg7rj821g5rLC /1scwgW435EgasVz4NdkYsKn1rSK+ISB0bV49oneCefkvEQbuWPk0vGuoa1STA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1770039083; a=rsa-sha256; cv=none; b=QtTawiHm9eysPsDFJCtg7ZhlHfmZjVealpdZEPWrYQFVi6oOCbRBQ7dzJyRRywV+zqJylQ PxslZLxglezIVreDD07J1SOt8jeLkDNDWQY7xjKFFkw9vmn/bQVxgzCBByYf+kY5tcvdNx 2Olv+2QF0y8N5TfCfrwzJwso+THcMTAkImoNZ6uky1J8yW+tQ6Be27F0yxyaaa3bN8PV7N 7zdLJQ/E8uh9AOrLCH2AWgY2yqGHSVmxI6BudtAOgYiPmpeZV0tdUzJoTlwnNMy0B1emDZ B/y6UAcNGQQ5nchZRirNaZCFUM5qDTn89yQqiJKPbSRDbK+HlCxTTNPNI04Z8w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770039083; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WefFLAo6FOmnJIzJZRkzOrAS7WseRIBj723LBqHvReo=; b=MIiImoiUmy5Oq9UrrnFrswc0jPh3Vczk9K8DtL5V+k5hnKA+XHFhwQW4M58USjquPOwrtQ 3bm3qWrHdOgBftL6MCM10szx0CHTXWa8v2d6Gz8rFsCbwjEDsMNaWxfenJFSATKkMBWlsA /aloIpNlEgJCMydAqUUoOzEEmlMO9A7vMmjdKQ7zBJ+mlTS2dJG74kOV+kc3RzOp93nKbZ ntvJ9PFdxycqOgP6zGigwkAqhhQlRajkS7FDp2n5EXUujcucTUi9RfVRLXvdRBTh3drnBD l0T7HluSQPx+57ZEx5R9uFpzdlQW+mtjYabOv2AoYR6dZ/4Cuz+c2NKJ3UC1QA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4f4SF72Wg2zBtx for ; Mon, 02 Feb 2026 13:31:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 319d3 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 02 Feb 2026 13:31:23 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: 05322eec86ae - main - nvmecontrol: Always set the RAE bit on telemetry-log requests List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 05322eec86ae42a8f873ba10d8da61bd61b5b48f Auto-Submitted: auto-generated Date: Mon, 02 Feb 2026 13:31:23 +0000 Message-Id: <6980a72b.319d3.5a2586e0@gitrepo.freebsd.org> The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=05322eec86ae42a8f873ba10d8da61bd61b5b48f commit 05322eec86ae42a8f873ba10d8da61bd61b5b48f Author: Warner Losh AuthorDate: 2026-02-02 13:30:08 +0000 Commit: Warner Losh CommitDate: 2026-02-02 13:31:21 +0000 nvmecontrol: Always set the RAE bit on telemetry-log requests nvme-cli, as well as some vendor scripts, always set the RAE bit of the GET LOG PAGE request when retrieving telemetry logs to avoid the log getting reset to something new. Adopt that praactice here (nvme-cli telemetry-log does have a --rae option, but that just turns on the rae bit which defaults to being on: there's no way to turn it off). Sponsored by: Netflix Differential Revision: https://reviews.freebsd.org/D55017 --- sbin/nvmecontrol/telemetry.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sbin/nvmecontrol/telemetry.c b/sbin/nvmecontrol/telemetry.c index 72c304229a80..bfa1325974d5 100644 --- a/sbin/nvmecontrol/telemetry.c +++ b/sbin/nvmecontrol/telemetry.c @@ -136,7 +136,7 @@ telemetry_log(const struct cmd *f, int argc, char *argv[]) /* Read the log page */ size = sizeof(tlp); off = 0; - read_logpage(fd, NVME_LOG_TELEMETRY_HOST_INITIATED, nsid, 0, 0, 0, + read_logpage(fd, NVME_LOG_TELEMETRY_HOST_INITIATED, nsid, 0, 0, true, off, 0, 0, 0, &tlp, size); switch(opt.da) { case 1: @@ -158,7 +158,7 @@ telemetry_log(const struct cmd *f, int argc, char *argv[]) do { if (chunk > size) chunk = size; - read_logpage(fd, NVME_LOG_TELEMETRY_HOST_INITIATED, nsid, 0, 0, 0, + read_logpage(fd, NVME_LOG_TELEMETRY_HOST_INITIATED, nsid, 0, 0, true, off, 0, 0, 0, &buf, chunk); if (off == 0) { /*