From owner-freebsd-scsi@FreeBSD.ORG  Wed Apr 30 22:23:20 2003
Return-Path: <owner-freebsd-scsi@FreeBSD.ORG>
Delivered-To: freebsd-scsi@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 3419037B401
	for <scsi@freebsd.org>; Wed, 30 Apr 2003 22:23:20 -0700 (PDT)
Received: from panzer.kdm.org (panzer.kdm.org [216.160.178.169])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 5FD8143F93
	for <scsi@freebsd.org>; Wed, 30 Apr 2003 22:23:19 -0700 (PDT)
	(envelope-from ken@panzer.kdm.org)
Received: from panzer.kdm.org (localhost [127.0.0.1])
	by panzer.kdm.org (8.12.9/8.12.5) with ESMTP id h415NIPM007694;
	Wed, 30 Apr 2003 23:23:18 -0600 (MDT)
	(envelope-from ken@panzer.kdm.org)
Received: (from ken@localhost)
	by panzer.kdm.org (8.12.9/8.12.5/Submit) id h415NIH0007693;
	Wed, 30 Apr 2003 23:23:18 -0600 (MDT)
	(envelope-from ken)
Date: Wed, 30 Apr 2003 23:23:17 -0600
From: "Kenneth D. Merry" <ken@kdm.org>
To: Marcel Moolenaar <marcel@xcllnt.net>
Message-ID: <20030430232317.A7644@panzer.kdm.org>
References: <20030501001235.GA932@athlon.pn.xcllnt.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5.1i
In-Reply-To: <20030501001235.GA932@athlon.pn.xcllnt.net>;
	from marcel@xcllnt.net on Wed, Apr 30, 2003 at 05:12:35PM -0700
cc: scsi@freebsd.org
Subject: Re: [patch] Fix for ia64 tinderbox failure
X-BeenThere: freebsd-scsi@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: SCSI subsystem <freebsd-scsi.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-scsi>,
	<mailto:freebsd-scsi-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-scsi>
List-Post: <mailto:freebsd-scsi@freebsd.org>
List-Help: <mailto:freebsd-scsi-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-scsi>,
	<mailto:freebsd-scsi-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 01 May 2003 05:23:20 -0000

On Wed, Apr 30, 2003 at 17:12:35 -0700, Marcel Moolenaar wrote:
> Gang,
> 
> Please review the attached patch to fix the "variable may be used
> uninitialized" warning (and thus build failure) on ia64.

I just checked in a slightly different fix.  I just initialized maxsector
and block_len to 0 at the beginning of dagetcapacity().

I guess the ia64 backend isn't as smart as the i386 backend.

> Index: scsi_da.c
> ===================================================================
> RCS file: /home/ncvs/src/sys/cam/scsi/scsi_da.c,v
> retrieving revision 1.140
> diff -u -r1.140 scsi_da.c
> --- scsi_da.c	30 Apr 2003 13:36:51 -0000	1.140
> +++ scsi_da.c	1 May 2003 00:07:59 -0000
> @@ -1821,7 +1821,7 @@
>  		if (maxsector != 0xffffffff)
>  			goto done;
>  	} else
> -		goto done;
> +		goto fail;
>  
>  	rcaplong = (struct scsi_read_capacity_data_long *)rcap;
>  
> @@ -1858,6 +1858,8 @@
>  
>  	if (error == 0)
>  		dasetgeom(periph, block_len, maxsector);
> +
> +fail:
>  
>  	xpt_release_ccb(ccb);
>  

Ken
-- 
Kenneth Merry
ken@kdm.org