From nobody Tue Jul 8 04:28:25 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bbp591NbPz61VDc; Tue, 08 Jul 2025 04:28:29 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta004.cacentral1.a.cloudfilter.net (omta002.cacentral1.a.cloudfilter.net [3.97.99.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bbp584B1Pz49LW; Tue, 08 Jul 2025 04:28:28 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Authentication-Results: mx1.freebsd.org; none Received: from shw-obgw-4004a.ext.cloudfilter.net ([10.228.9.227]) by cmsmtp with ESMTPS id YygXuhMHY5MqyYzwRuY7pg; Tue, 08 Jul 2025 04:28:27 +0000 Received: from spqr.komquats.com ([70.66.136.217]) by cmsmtp with ESMTPSA id YzwQumImLJhBPYzwQuLY7M; Tue, 08 Jul 2025 04:28:27 +0000 X-Auth-User: cschuber X-Authority-Analysis: v=2.4 cv=QY3Fvdbv c=1 sm=1 tr=0 ts=686c9e6b a=h7br+8Ma+Xn9xscxy5znUg==:117 a=h7br+8Ma+Xn9xscxy5znUg==:17 a=kj9zAlcOel0A:10 a=Wb1JkmetP80A:10 a=6I5d2MoRAAAA:8 a=EkcXrb_YAAAA:8 a=S-1b6JwnAAAA:8 a=YxBL1-UpAAAA:8 a=Y9XXBGl_wdZf-F10BAYA:9 a=CjuIK1q_8ugA:10 a=LK5xJRSDVpKd5WXXoEvA:22 a=jHPkhvgQCurpnRnmkKlz:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id 7103EEC; Mon, 07 Jul 2025 21:28:25 -0700 (PDT) Received: by slippy.cwsent.com (Postfix, from userid 1000) id 669BF20E; Mon, 07 Jul 2025 21:28:25 -0700 (PDT) X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.8+dev Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: "Herbert J. Skuhra" cc: Cy Schubert , Dima Panov , Cy Schubert , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 7e35117eb07f - main - Makefile: Hook MIT KRB5 into the build In-reply-to: References: <202506160251.55G2pwx4063231@gitrepo.freebsd.org> <20250620073050.7f03f74e@slippy> <20250707230446.F279E3A1@slippy.cwsent.com> Comments: In-reply-to "Herbert J. Skuhra" message dated "Tue, 08 Jul 2025 03:18:23 +0200." List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Mon, 07 Jul 2025 21:28:25 -0700 Message-Id: <20250708042825.669BF20E@slippy.cwsent.com> X-CMAE-Envelope: MS4xfOdx1inv1ZxtqQ869X4bNLJ2ONGr44BoYLBfxgtHgNmP2+s2qFImO+QgGuPzhOqmfCQ9r7nCM+sXW55lN7O1QhU/zTANq0c/L789whyW8e1TYC0tLa3+ OSYwd2gzP1KAC8/ovjMNZL56ybsqoLj6ToJi8z31qzskAWRJpO9FTTK5rgTolvru7CJYJGJfRYYyRKKtbYOQpqGRHe9RBzTWh/5HKYSXi0X0TiwsbE7E6W8I bIxOaxtAj+N1PssgQnxIM5RYh6XzQff70rZt9UpB7o6iJr98hWRz3pvfUuxdmGcrmo91FmH43KDIen7aR+NGghe/z3S2bco3pTEcmpF07vwOadEDfBrQX7Vy lktiW8rLRRnSNDu53DwYapaIuTwS9g== X-Rspamd-Queue-Id: 4bbp584B1Pz49LW X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:16509, ipnet:3.96.0.0/15, country:US] In message , "Herbert J. Skuhra" writes: > On Mon, Jul 07, 2025 at 04:04:46PM -0700, Cy Schubert wrote: > > In message , "Herbert J. Skuhra" writes: > > > On Mon, Jul 07, 2025 at 10:36:31PM +0300, Dima Panov wrote: > > > > Hello! > > > > > > > > > > > > BTW, it looks like symlink for libkadm5clnt.so is broken and produced a > bad > > > file > > > > $ ls -la libkadm5clnt > > > > lrwxr-xr-x 1 root wheel 13 7 Jul 20:40 libkadm5clnt -> kadm5clnt_mit > > > > > > > > instead of assumed libkadm5clnt.so -> kadm5clnt_mit.so > > > > > > > > > > > > Please review: > > > > > > > > diff --git a/krb5/lib/kadm5clnt/Makefile b/krb5/lib/kadm5clnt/Makefile > > > > index e377f95f5b6e..be09dd3e210e 100644 > > > > --- a/krb5/lib/kadm5clnt/Makefile > > > > +++ b/krb5/lib/kadm5clnt/Makefile > > > > @@ -88,7 +88,7 @@ ${CHPASS_UTIL_STRINGS_ERR_C}: ${CHPASS_UTIL_STRINGS_E > RR} > > > > rm -f et-c-${.PREFIX}.et et-c-${.PREFIX}.c > > > > > > > > afterinstall: > > > > - ${INSTALL_LIBSYMLINK} ${SHLIB} ${DESTDIR}${LIBDIR}/libkadm5clnt > > > > + ${INSTALL_LIBSYMLINK} ${SHLIB_NAME} ${DESTDIR}${LIBDIR}/libkadm > 5cln > > > t.so > > > > > > > > .include > > > > > > This produces a valid symlink that 'make delete-old' wants to > > > remove again: > > > > > > lrwxr-xr-x 1 root wheel 23 Jul 7 22:26 /usr/lib/libkadm5clnt.so -> > > > libkadm5clnt_mit.so.121 > > > > > > # make delete-old > > > >>> Removing old files (only deletes safe to delete libs) > > > remove /usr/lib/libkadm5clnt.so? > > > > Thanks Dima and Herbert for reporting this. It's been fixed. > > Cy, I am sorry for not being more precise. > > Dima's change, which hasn't been commited yet, fixes the real issue of > creating a bad symlink. > > I just wanted to add that his fix also needs removal of > usr/lib/libkadm5clnt.so in tools/build/mk/OptionalObsoleteFiles.inc. > > Maybe usr/lib/libkadm5clnt should be added to OptionalObsoleteFiles.inc? libkadm5clnt.so is a legitimate symlink for both MIT and Heimdal. In the case of Heimdal it points to libkadm5clnt.so.11. Whereas for MIT it points to libkadm5clnt_mit.so.121. There is o libkadm5clnt in MIT. It is libkadm5clnt_mit. You can see this in the port with pkg info -l as follows: slippy$ pkg info -l krb5 | grep libkadm5clnt /usr/local/lib/libkadm5clnt.so /usr/local/lib/libkadm5clnt_mit.so /usr/local/lib/libkadm5clnt_mit.so.12 /usr/local/lib/libkadm5clnt_mit.so.12.0 slippy$ -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org e**(i*pi)+1=0